fix: mark customEventHandlers as optional #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CristianDeluxe
requested review from
makandz and
jdw1996
and removed request for
a team
caffeinated-pixels
approved these changes
Jul 11, 2024
caffeinated-pixels
changed the title
thedaviddias
pushed a commit
that referenced
this pull request
Jul 11, 2024
## [4.2.13](v4.2.12...v4.2.13) (2024-07-11) ### Bug Fixes * mark customEventHandlers as optional ([#138](#138)) ([0f4589c](0f4589c))
|
🎉 This PR is included in version 4.2.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sorry, my PR above generates a new error as we define a default value for customEventHandlers but at the same time it is marked as required.
Since it has a default value it does not need to be required.
So the error is easily fixed
Related error: