Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #972
Updates to
Swapchain
&HPPSwapchain
surface_formats
andpreset_modes
which are only ever used during the swapchain creation in the constructorimage_usage_flags
member in favor of theSwapchainProperties
/HPPSwapchainProperties
image_usage
member/
HPPSwapchainProperties` parameterSwapchainProperties::image_usage
fromVkImageUsageFlags
tostd::set<VkImageUsageFlagBits>
VkImageUsageFlags
everywhere in the C bindings code, but then all the overloaded constructors and downstream members can't distinguish betweenVkImageUsageFlags
anduint32_t
. This isn't a problem in the C++ bindings becausevk::ImageUsageFlags
isn't the same fundamental type asuint32_t
.Other files
HPPApiVulkanSample
andHPPRenderContext
swapchain utility functions to usevk::ImageUsageFlags
instead ofstd::set<vk::ImageUsageFlagBits>
HPPRenderContext
andRenderContext
to remove the unusedswapchain_properties
member.General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including: