Add test plan for SYCL_KHR_GROUP_INTERFACE
#1023
Conversation
Signed-off-by: Michael Aziz <[email protected]>
@Pennycook can you review this? I think you're closer to this API than me, so you'd do a better job reviewing the test plan. |
|
I didn't include any of the C++ 23 member functions in this test plan since I don't have a working implementation of |
Could you use https://github.com/kokkos/mdspan? That's what I've used for |
I'll try using this to add the missing test cases. |
| * Define a `sycl::group<Dimensions>` named `group` using `it.get_group()`. | ||
| * Define a `sycl::khr::work_group<Dimensions>` named `work_group` using `it.get_group()`. | ||
| * Define a `sycl::khr::work_item<sycl::khr::work_group<Dimensions>>` named `item` using `sycl::khr::get_item(work_group)`. | ||
| * Check that `item.id()` returns a `work_item<>::id_type`. |
There was a problem hiding this comment.
Checking: Are you using work_item<>::id_type here as a shorthand for work_item<sycl::khr::work_group<Dimensions>>::id_type?
Somebody might misinterpret this as work_item<> (i.e., the class with the template arguments defaulted). I've not reviewed one of these test plans before, but if you think it's important to be unambiguous here you could say something like:
| * Check that `item.id()` returns a `work_item<>::id_type`. | |
| * Define a type alias `wg_item` equal to `sycl::khr::work_item<sycl::khr::work_group<Dimensions>>`. | |
| * Check that `item.id()` returns a `wg_item::id_type`. |
Same comment for the other work_item functions.
No description provided.