fix: multiselect was not saving values when it had no focus #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
KevinVandy
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an edit modal had a multiselect input and the pill "X" button was clicked the value was not removed. This is because the
saveInputValueToRowCachefunction was only called in theonBlurhandler. Since the input never gains focus in this case, the handler never gets called and the input's value does not get saved in the row's cache.This fix calls
saveInputValueToRowCacheinside theonChangehandler only when the input doesn't have focus.Closes #381