Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mantine 7.9 & React 18.3 #323

Merged
merged 2 commits into from
May 3, 2024
Merged

Mantine 7.9 & React 18.3 #323

merged 2 commits into from
May 3, 2024

Conversation

alessandrojcm
Copy link
Collaborator

Opening this as a draft since we have an issue here:

  • Updating the library itself to Mantine 7.9 and React 18.3 works fine (Storybook works, etc).
  • Updating the docs site to Next 14.2, React 18.3 and Mantine 7.9 also works fine.
  • The issue are the examples, since they pull MRT from the registry instead of the workspace, they are pulling MRT beta.1 which uses React 18.2 and we get a TypeError: Cannot read properties of null (reading 'useState') which (I think) is due to the version mismatch. We would need a beta.2 release with React 18.3 to fix this.

@alessandrojcm alessandrojcm added the V2 Issue with MRT V2 label May 3, 2024
@alessandrojcm alessandrojcm self-assigned this May 3, 2024
Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mantine-react-table ❌ Failed (Inspect) May 3, 2024 10:46am
mantine-react-table-storybook ✅ Ready (Inspect) Visit Preview May 3, 2024 10:46am

@alessandrojcm
Copy link
Collaborator Author

Any thoughts here? @KevinVandy

@KevinVandy
Copy link
Owner

You shouldn't ever need to worry about the examples dep versions. If you installed only from the root of the monorepo, they should be using the node_modules from just the next app (docs) and not downloading their own packages at all.

@KevinVandy KevinVandy marked this pull request as ready for review May 3, 2024 18:39
@KevinVandy KevinVandy merged commit d9c0c8e into v2 May 3, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 Issue with MRT V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants