Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

212 global column ordering dosent have t #217

Merged
merged 2 commits into from
Dec 7, 2023
Merged

212 global column ordering dosent have t #217

merged 2 commits into from
Dec 7, 2023

Conversation

alessandrojcm
Copy link
Collaborator

@alessandrojcm alessandrojcm commented Dec 7, 2023 •
edited
Loading

  • Adds box shadow to table head when hovering.
  • Fixes hovered and target state when dradding items from the global menu ordering item

Closes #212

@alessandrojcm alessandrojcm self-assigned this Dec 7, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 7, 2023

Someone is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel.

A member of the Team first needs to authorize it.

@alessandrojcm alessandrojcm marked this pull request as ready for review December 7, 2023 15:00
@posabsolute
Copy link
Contributor

@alessandrojcm is the 209 files change intended?

@alessandrojcm
Copy link
Collaborator Author

@alessandrojcm is the 209 files change intended?

No, I don't know what is wrong with my fork is like it has not got the changes from this repo. Let me check.

@alessandrojcm alessandrojcm force-pushed the 212-global-column-ordering-dosent-have-t branch from de53296 to cc13ed3 Compare December 7, 2023 15:23
@alessandrojcm
Copy link
Collaborator Author

Fixed it @posabsolute

@alessandrojcm alessandrojcm merged commit 96c9da9 into KevinVandy:v2 Dec 7, 2023
0 of 3 checks passed
@alessandrojcm alessandrojcm deleted the 212-global-column-ordering-dosent-have-t branch December 7, 2023 15:25
KevinVandy
KevinVandy reviewed Dec 8, 2023
View reviewed changes
packages/mantine-react-table/src/head/MRT_TableHeadRow.module.css
@@ -4,6 +4,7 @@
var(--mantine-color-dark-7)
);
display: table-row;
box-shadow: 0 rem(4) rem(8) var(--mantine-color-dark-2);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this box shadow does not look very good. removing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinVandy KevinVandy KevinVandy left review comments

@posabsolute posabsolute posabsolute approved these changes

@naughton naughton Awaiting requested review from naughton

Assignees

@alessandrojcm alessandrojcm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Global column ordering dosent have the dotted border and wrong spacing
4 participants
@alessandrojcm @posabsolute @KevinVandy @alessandro-cuppari