Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to get display columns to go in and out on state change #193

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

naughton
Copy link
Contributor

let me know if i'm going down the wrong path here...

Copy link

vercel bot commented Nov 21, 2023

@naughton is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel.

A member of the Team first needs to authorize it.

@posabsolute
Copy link
Contributor

Personally I like it, looks cleaner

@alessandrojcm
Copy link
Collaborator

Me too, way easier to follow

initState.columnOrder =
initState.columnOrder ?? getDefaultColumnOrderIds(tableOptions);
// initState.columnOrder =
// initState.columnOrder ?? getDefaultColumnOrderIds(tableOptions);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but a bit concerned about what's going on here

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem introduced here is that this is simply turning off the column ordering feature entirely within MRT. That's why dynamic columns seem to start working. This means though that when column ordering is turned on by the developer, everything breaks again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I knew I was out over my skis here, which is where I stopped and solved it another way in my app.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just got stuff working. Check out the new dynamic editing and row number example @naughton

@KevinVandy KevinVandy marked this pull request as ready for review December 5, 2023 22:33
@KevinVandy KevinVandy merged commit 33d8700 into KevinVandy:v2 Dec 5, 2023
0 of 3 checks passed
@naughton naughton deleted the late-bound-enables branch February 15, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants