-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to get display columns to go in and out on state change #193
Conversation
@naughton is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel. A member of the Team first needs to authorize it. |
Personally I like it, looks cleaner |
Me too, way easier to follow |
initState.columnOrder = | ||
initState.columnOrder ?? getDefaultColumnOrderIds(tableOptions); | ||
// initState.columnOrder = | ||
// initState.columnOrder ?? getDefaultColumnOrderIds(tableOptions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but a bit concerned about what's going on here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem introduced here is that this is simply turning off the column ordering feature entirely within MRT. That's why dynamic columns seem to start working. This means though that when column ordering is turned on by the developer, everything breaks again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I knew I was out over my skis here, which is where I stopped and solved it another way in my app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just got stuff working. Check out the new dynamic editing and row number example @naughton
let me know if i'm going down the wrong path here...