Add filter to globally disable font loading #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the code_block_pro_load_fonts filter by checking loadFonts value before initiating font loading. This allows users to globally disable custom font loading via a filter when needed. This change: - Short-circuits font loading if loadFonts is false - Maintains backward compatibility
Add code_block_pro_load_fonts filter to allow global control over font loading behavior. The filter value is passed to the frontend JavaScript contexts through the codeBlockPro object.
Implementation:
- Adds new loadFonts property to window.codeBlockPro
- Default value of true maintains existing behavior
- Can be disabled via add_filter('code_block_pro_load_fonts', '__return_false')
|
It's a good idea but my only concern here is adding a new api I'd have to support forever, and I'm about to start a rewrite of the plugin. In the rewrite I want to have global profiles that would make changes like this trivial. It will be a lot of work though to rewrite it. Were you not able to do it by nulling the plugin Url? |
|
I was just worried that since it wasn't specific to the fonts that it wasn't necessary a permanent solution |
|
The only thing that would mess up is whether I added a new feature that pulled in an external asset which I can't imagine doing. I think you're safe to do it but I'll think a bit more on adding an API to disable it directly too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a filter that allows users to globally disable custom font loading.
Changes
code_block_pro_load_fontsfilter with default value of trueUsage
Users can disable font loading globally by adding this to their theme or plugin: