Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update octokit monorepo (major) #1113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): update octokit monorepo (major) #1113

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 28, 2024 •
edited

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@octokit/plugin-retry 6.0.1 -> 7.1.1 age adoption passing confidence
@octokit/plugin-throttling 8.2.0 -> 9.3.0 age adoption passing confidence

Release Notes

octokit/plugin-retry.js (@​octokit/plugin-retry)

v7.1.1

Compare Source

Bug Fixes

v7.1.0

Compare Source

Features

v7.0.4

Compare Source

Bug Fixes

v7.0.3

Compare Source

Bug Fixes

v7.0.2

Compare Source

Bug Fixes

v7.0.1

Compare Source

Bug Fixes

v7.0.0

Compare Source

Features
BREAKING CHANGES
  • package is now ESM
octokit/plugin-throttling.js (@​octokit/plugin-throttling)

v9.3.0

Compare Source

Features

v9.2.1

Compare Source

Bug Fixes

v9.2.0

Compare Source

Features
  • routes changed from repository_id to nwo and enterprise groups now includes the enterprise in route (#​684) (734bcba)

v9.1.0

Compare Source

Features

v9.0.4

Compare Source

Bug Fixes

v9.0.3

Compare Source

Bug Fixes

v9.0.2

Compare Source

Bug Fixes

v9.0.1

Compare Source

Bug Fixes

v9.0.0

Compare Source

Features
BREAKING CHANGES
  • package is now ESM

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the renovate label Feb 28, 2024
@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch 4 times, most recently from e53b25d to 2e07eda Compare March 2, 2024 04:58
@Kesin11
Copy link
Owner

Kesin11 commented Mar 2, 2024

tsc error

$ npm run check

> [email protected] check
> tsc --noEmit

src/client/github_client.ts:2:28 - error TS2307: Cannot find module '@octokit/plugin-throttling' or its corresponding type declarations.

2 import { throttling } from '@octokit/plugin-throttling'
                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/client/github_client.ts:30:23 - error TS7006: Parameter 'retryAfter' implicitly has an 'any' type.

30         onRateLimit: (retryAfter, options: any, _octokit, retryCount) => {
                         ~~~~~~~~~~

src/client/github_client.ts:30:49 - error TS7006: Parameter '_octokit' implicitly has an 'any' type.

30         onRateLimit: (retryAfter, options: any, _octokit, retryCount) => {
                                                   ~~~~~~~~

src/client/github_client.ts:30:59 - error TS7006: Parameter 'retryCount' implicitly has an 'any' type.

30         onRateLimit: (retryAfter, options: any, _octokit, retryCount) => {
                                                             ~~~~~~~~~~

src/client/github_client.ts:40:32 - error TS7006: Parameter '_retryAfter' implicitly has an 'any' type.

40         onSecondaryRateLimit: (_retryAfter, options: any, _octokit, _retryCount) => {
                                  ~~~~~~~~~~~

src/client/github_client.ts:40:59 - error TS7006: Parameter '_octokit' implicitly has an 'any' type.

40         onSecondaryRateLimit: (_retryAfter, options: any, _octokit, _retryCount) => {
                                                             ~~~~~~~~

src/client/github_client.ts:40:69 - error TS7006: Parameter '_retryCount' implicitly has an 'any' type.

40         onSecondaryRateLimit: (_retryAfter, options: any, _octokit, _retryCount) => {

It seems to be resolved by octokit/plugin-throttling.js#678 but Renovate does not bump to @octokit/plugin-retry v9.0.2 due to stability days config.
So, I will wait for next week Renovate work.

@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch from 2e07eda to c5aefa9 Compare March 4, 2024 01:21
@Kesin11
Copy link
Owner

Kesin11 commented Mar 5, 2024

@octokit/plugin-retry has bumped to v9.0.3 but type check still failed.
This error may be due to the fact both packages were changed to ESM.

Run npm run check

> [email protected] check
> tsc --noEmit

src/client/github_client.ts(2[4](https://github.com/Kesin11/CIAnalyzer/actions/runs/8134579006/job/22227709175?pr=1113#step:6:5),38): error TS234[5](https://github.com/Kesin11/CIAnalyzer/actions/runs/8134579006/job/22227709175?pr=1113#step:6:6): Argument of type 'typeof throttling' is not assignable to parameter of type 'OctokitPlugin'.
  Types of parameters 'octokit' and 'octokit' are incompatible.
    Type 'import("/__w/CIAnalyzer/CIAnalyzer/node_modules/@octokit/rest/node_modules/@octokit/core/dist-types/index").Octokit' is not assignable to type 'import("/__w/CIAnalyzer/CIAnalyzer/node_modules/@octokit/core/dist-types/index").Octokit'.
      The types of 'hook.before' are incompatible between these types.
        Type '<Name extends keyof Hooks>(name: Name, beforeHook: BeforeHook<GetType<Hooks[Name], "Options", "O">>) => void' is not assignable to type '<Name extends keyof Hooks>(name: Name, beforeHook: BeforeHook<GetType<Hooks[Name], "Options">>) => void'.
          Types of parameters 'beforeHook' and 'beforeHook' are incompatible.
            Types of parameters 'options' and 'options' are incompatible.
              Type 'GetType<Hooks[Name], "Options", "O">' is not assignable to type 'GetType<Hooks[Name], "Options">'.
                Type 'Hooks[Name][keyof Hooks[Name] & "Options"] | ("O" extends keyof Hooks[Name] ? Hooks[Name][keyof Hooks[Name] & "O"] : any)' is not assignable to type 'GetType<Hooks[Name], "Options">'.
                  Type 'Hooks[Name][keyof Hooks[Name] & "Options"]' is not assignable to type 'GetType<Hooks[Name], "Options">'.
                    Type 'Hooks[Name]["Options"]' is not assignable to type 'GetType<Hooks[Name], "Options">'.
src/client/github_client.ts(30,23): error TS700[6](https://github.com/Kesin11/CIAnalyzer/actions/runs/8134579006/job/22227709175?pr=1113#step:6:7): Parameter 'retryAfter' implicitly has an 'any' type.
src/client/github_client.ts(30,49): error TS[7](https://github.com/Kesin11/CIAnalyzer/actions/runs/8134579006/job/22227709175?pr=1113#step:6:8)006: Parameter '_octokit' implicitly has an 'any' type.
src/client/github_client.ts(30,5[9](https://github.com/Kesin11/CIAnalyzer/actions/runs/8134579006/job/22227709175?pr=1113#step:6:10)): error TS7006: Parameter 'retryCount' implicitly has an 'any' type.
src/client/github_client.ts(40,32): error TS7006: Parameter '_retryAfter' implicitly has an 'any' type.
src/client/github_client.ts(40,59): error TS7006: Parameter '_octokit' implicitly has an 'any' type.
src/client/github_client.ts(40,69): error TS7006: Parameter '_retryCount' implicitly has an 'any' type.
``

@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch 3 times, most recently from 162b1fe to fbc9c72 Compare March 14, 2024 15:43
@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch from fbc9c72 to 01291d0 Compare March 21, 2024 21:12
@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch 2 times, most recently from 2d4deb4 to 28983f1 Compare April 6, 2024 22:20
@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch 2 times, most recently from 8c2eaec to f7715c7 Compare April 25, 2024 17:11
@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch 3 times, most recently from 2f9f9c4 to dbba469 Compare May 3, 2024 01:50
@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch 2 times, most recently from 276e50f to f1d2f54 Compare May 9, 2024 18:11
@renovate renovate bot force-pushed the renovate/major-octokit-monorepo branch from f1d2f54 to a4c8411 Compare May 24, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
renovate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Kesin11