refactor : product 관련 설정 변경

[chan99k]

💡 Motivation and Context

Product 관련 세부 스펙 변경

🔨 Modified

Product 관련 설정 변경

• V1.1.1__alter_brand_and_product_table.sql ->> 실행 이력 지우고 다시 재실행 필요
• SafetyStatus enum 필드와 converter 추가
• product 필드명 변경… (description -> imgSource, isViolation -> SafetyStatus)
• SafetyStatus enum 추가

🌟 More

---

📋 커밋 전 체크리스트

• 추가/변경에 대한 단위 테스트를 완료하였습니다.
• 컨벤션에 맞게 작성하였습니다.

🤟🏻 PR로 완료된 이슈

closes #69

[cr-gpt]

Here are some observations and suggestions for your code patch:

1. Import Statement: You imported the SafetyStatus class, which is not mentioned in the code patch. Make sure you're using it correctly.

2. ProductDto Constructor: In the constructor, you have Long productNo, but you should specify the appropriate type for the field. If it's a numeric ID, consider using Long or Integer.

3. Naming Convention: Follow the Java naming conventions. Class names should start with an uppercase letter, so ProductDto should be ProductDTO. Similarly, variable names like productNo should start with a lowercase letter (productNo).

4. Commented Code: Remove commented-out code or TODO/FIXME comments that are no longer relevant or clear.

5. Field Name Change: It seems that the field isViolation has been replaced by safetyStatus. Ensure that this change is reflected in other parts of the code that use this field.

6. Missing Setter Method: The ProductDto class defined as a record does not have setter methods. If you need mutability, consider converting it to a regular class or manually create setters.

7. Usage of entity.getImage(): In the from method, you call entity.getImage(), but there is no corresponding field for image in the constructor or the fields list. Verify if this is intentional or if you missed adding it.

Overall, the provided code snippet looks mostly fine, but do carefully review the areas mentioned above based on the complete codebase and testing requirements.

[linglong67]

LGTM!

[linglong67]

별 건 아니지만 코드 컨벤션 할 때, return 전에 빈 줄 하나 추가하기로 했었던 것 같아요~

[HyunJunSon]

여기는 BIGSERIAL이 맞지 않나요?

[HyunJunSon]

여기도 변경해야 할듯 합니다

[HyunJunSon]

여기도 변경해야 할듯 합니다

[HyunJunSon]

이건 무슨 어노테이션인가요? 자동으로 convert 되는건가요?

[cr-gpt]

1. In the ProductDto class, there is a comment mentioning that the toEntity method needs to be changed due to changes in the Product table. It would be helpful to review and update the toEntity method accordingly.

2. It seems that the variables description, declareNo, and isViolation have been removed from the ProductDto record. Make sure this change aligns with the required functionality. If these fields are still necessary, they need to be incorporated back into the record.

3. Check if the parameter names in the of and from methods match the field names in the Product entity class. It's important to ensure the correct mapping between the DTO and the entity.

4. Verify if the variable imageSource corresponds to the property image in the Product entity, as it was referenced in the from method. If they represent the same information, make sure to use consistent terminology.

5. Confirm that the type of the safetyStatus field in the ProductDto and Product entity matches correctly. It appears to be of type SafetyStatus, so ensure this type is properly defined and implemented.

6. Consider adding appropriate error handling or validation checks for the input parameters in the of method, if necessary.

Overall, it's important to carefully review and verify the changes made to ensure that the code behaves as expected and that all necessary fields are properly handled in the DTO and entity classes.

[HyunJunSon]

LGTM