[review] f1-washpedia

module-api/src/main/java/com/kernel360/commoncode/controller/CommonCodeController.java

@@ -20,8 +20,12 @@
 public class CommonCodeController {
 
     private final CommonCodeService commonCodeService;
+
+    //
     @GetMapping("/{codeName}")
     public ResponseEntity<ApiResponse<List<CommonCodeDto>>> getCommonCode (@PathVariable String codeName){
+
+        //
         List<CommonCodeDto> codes = commonCodeService.getCodes(codeName);
 
         return ApiResponse.toResponseEntity(GET_COMMON_CODE_SUCCESS, codes);

module-api/src/main/java/com/kernel360/commoncode/service/CommonCodeService.java

@@ -17,12 +17,14 @@ public class CommonCodeService {
 
     public List<CommonCodeDto> getCodes(String codeName) {
 
+        //
         return commonCodeRepository.findAllByUpperNameAndIsUsed(codeName,true)
                                    .stream()
                                    .map(CommonCodeDto::from)
                                    .toList();
     }
 
+    //
     public List<CommonCodeDto> getCodesMapper(String codeName) {
 
         return commonCodeMapper.findAllByUpperNameAndIsUsed(codeName,true)

module-api/src/main/java/com/kernel360/global/Interceptor/AcceptInterceptor.java

@@ -25,6 +25,7 @@ public boolean preHandle(HttpServletRequest request, HttpServletResponse respons
         boolean result = true;
         String requestToken = request.getHeader("Authorization");
 
+        //
         if (requestToken == null || requestToken.isEmpty()) { throw new BusinessException(AcceptInterceptorErrorCode.DOSE_NOT_EXIST_REQUEST_TOKEN); }
 
         if (!validRequestToken(requestToken)) { throw new BusinessException(AcceptInterceptorErrorCode.FAILED_VALID_REQUEST_TOKEN); }

module-api/src/main/java/com/kernel360/main/controller/MainContoller.java

@@ -18,17 +18,22 @@
 @RestController
 @RequestMapping
 @RequiredArgsConstructor
+
+//
 public class MainContoller {
     private final ProductService productService;
     private final MainService mainService;
 
+    //
     @GetMapping("/banner")
     ResponseEntity<ApiResponse<BannerDto>> getBanner() {
 
         return ApiResponse.toResponseEntity(BannerBusinessCode.GET_BANNER_DATA_SUCCESS, mainService.getBanner());
     }
 
+
     @GetMapping("/recommend-products")
+    //
     ResponseEntity<ApiResponse<Page<RecommendProductsDto>>> getRecommendProducts(Pageable pageable) {
         Page<RecommendProductsDto> recommendProductList = productService.getRecommendProductList(pageable);
 
@@ -37,6 +42,8 @@ ResponseEntity<ApiResponse<Page<RecommendProductsDto>>> getRecommendProducts(Pag
     }
 
     @GetMapping("/products/rank")
+
+    //
     ResponseEntity<ApiResponse<Page<ProductDto>>> getProducts(
             @RequestParam(name = "sortType", defaultValue = "viewCnt-order") Sort sortType, Pageable pageable) {
         Page<ProductDto> productDtos = sortType.sort(productService, pageable);

module-api/src/main/java/com/kernel360/main/controller/Sort.java

@@ -6,6 +6,7 @@
 import org.springframework.data.domain.Pageable;
 
 
+//
 public enum Sort {
 
     VIEW_COUNT_PRODUCT_ORDER("viewCnt-order") {

module-api/src/main/java/com/kernel360/member/config/AuditConfig.java

@@ -8,6 +8,7 @@
 
 import java.util.Optional;
 
+//
 @Configuration
 public class AuditConfig implements AuditorAware<String> {
     @Override

module-api/src/main/java/com/kernel360/member/dto/MemberDto.java

@@ -9,10 +9,13 @@
 /**
  * DTO for {@link com.kernel360.member.entity.Member}
  */
+
+
 public record MemberDto(Long memberNo,
                         String id,
                         String email,
                         String password,
+                        //
                         String gender,
                         String age,
                         LocalDate createdAt,

module-api/src/main/java/com/kernel360/member/dto/MemberInfo.java

@@ -16,6 +16,8 @@ static MemberInfo of(
         return new MemberInfo(id, email, gender, age);
     }
 
+
+    //
     public Member toEntity() {
         return Member.of(
                 this.id,

module-api/src/main/java/com/kernel360/member/service/MemberService.java

@@ -59,6 +59,7 @@ protected Member getNewJoinMemberEntity(MemberDto requestDto) {
         int ageOrdinal;
 
         try {
+            // enum으로 받으면 다음과 같은 작업을 할 필요가 없음 .
             genderOrdinal = Gender.valueOf(requestDto.gender()).ordinal();
             ageOrdinal = Age.valueOf(requestDto.age()).ordinal();
         } catch (Exception e) {
@@ -124,6 +125,8 @@ public boolean idDuplicationCheck(String id) {
 
     @Transactional(readOnly = true)
     public boolean emailDuplicationCheck(String email) {
+
+        //
         Member member = memberRepository.findOneByEmail(email);
 
         return member != null;
@@ -188,6 +191,7 @@ public Map<String, Object> getCarInfo(String token) {
         Member member = memberRepository.findOneById(id);
         CarInfoDto carInfoDto = CarInfoDto.from(member.getCarInfo());
 
+        //
         return Map.of(
                 "car_info", carInfoDto,
                 "segment_options", commonCodeService.getCodes("segment"),
@@ -200,6 +204,7 @@ public Map<String, Object> getCarInfo(String token) {
 
     @Transactional
     public void saveWashInfo(WashInfoDto washInfoDto, String token) {
+        //
         String id = JWT.ownerId(token);
         Member member = memberRepository.findOneById(id);
         WashInfo washInfo = WashInfo.of(washInfoDto.washNo(), washInfoDto.washCount(), washInfoDto.monthlyExpense(), washInfoDto.interest());

module-api/src/main/java/com/kernel360/mypage/controller/MyPageController.java

@@ -15,10 +15,13 @@
 
 @Slf4j
 @RestController
+//
 @RequestMapping("/mypage")
 @RequiredArgsConstructor
 public class MyPageController {
     private final MemberService memberService;
+
+    //
     private final ProductService productService;
 
     @GetMapping("/member")
@@ -45,6 +48,7 @@ ResponseEntity<ApiResponse<Void>> memberDelete(@RequestHeader("Authorization") S
 
 
     @PostMapping("/member")
+    //
     ResponseEntity<ApiResponse<String>> validatePassword(@RequestBody String password, @RequestHeader("Authorization") String authToken) {
         memberService.changePassword(password, authToken);
 

module-api/src/main/java/com/kernel360/product/controller/ProductController.java

@@ -19,6 +19,7 @@ public class ProductController {
 
     private final ProductService productService;
 
+    //
     @GetMapping("/products")
     ResponseEntity<ApiResponse<List<ProductDto>>> findProductList(){
         final List<ProductDto> productDtoList = productService.getProductList();

module-domain/src/main/java/com/kernel360/auth/entity/Auth.java

@@ -16,6 +16,8 @@ public class Auth extends BaseEntity {
     @Id
     @GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "auth_id_gen")
     @SequenceGenerator(name = "auth_id_gen", sequenceName = "auth_auth_no_seq")
+
+    //
     @Column(name = "auth_no", nullable = false)
     private Long authNo;
 

module-domain/src/main/java/com/kernel360/base/BaseRawEntity.java

@@ -13,6 +13,7 @@
 
 @Getter
 @MappedSuperclass
+// 중복
 @EntityListeners(AuditingEntityListener.class)
 public class BaseRawEntity {
     // FIXME :: createdAt 자동 생성시, update 로직 진행중에 null or transient 문제가 발생. 임시방편으로 직접 지정하였으나 이후 수정 필요

module-domain/src/main/java/com/kernel360/member/entity/Member.java

@@ -88,6 +88,7 @@ public static Member createJoinMember(String id, String email, String password,
     /**
      * joinMember Binding
      **/
+    //
     private Member(String id, String email, String password, int gender, int age) {
         this.id = id;
         this.email = email;

module-domain/src/main/java/com/kernel360/product/repository/ProductRepository.java

@@ -16,12 +16,13 @@
 public interface ProductRepository extends JpaRepository<Product, Long> {
     Page<Product> findByProductNameContaining(String keyword, Pageable pageable);
 
+    //
     Page<Product> findAllByOrderByViewCountDesc(Pageable pageable);
 
     Page<Product> findTop5ByOrderByProductNameDesc(Pageable pageable);
 
     Page<Product> findAllBySafetyStatusEquals(SafetyStatus safetyStatus, Pageable pageable);
-
+거
     Page<Product> findAllByOrderByCreatedAtDesc(Pageable pageable);
 
     @Query(value = "SELECT p FROM Product p WHERE p.productName = :productName "