Skip to content

Commit

Permalink
Remove Deferred cancellation on client reset
Browse files Browse the repository at this point in the history
See twisted#546.

We have been running a similar patch on our enterprise production systems for about 6 months with no issues, and critically we have stopped getting issues on client resets.
  • Loading branch information
KentShikama committed Aug 16, 2022
1 parent 6a3f013 commit 320d22a
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/klein/_resource.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,6 @@ def _execute() -> Deferred:
d = maybeDeferred(
self._app.execute_endpoint, endpoint, request, **kwargs
)

request.notifyFinish().addErrback( # type: ignore[attr-defined]
lambda _: d.cancel(),
)

return d

d = maybeDeferred(_execute)
Expand Down

0 comments on commit 320d22a

Please sign in to comment.