Update MSVR in README.md

[fabienbellanger]

Update MSVR in README.md

[Keats]

I would be tempted to remove that line and just add a link to the line in the CI file (https://github.com/Keats/validator/blob/master/.github/workflows/ci.yml#L11) to avoid keeping it in multiple places. Thoughts?

[fabienbellanger]

Yes, this will prevent mistakes.
Why not add it to the Cargo.toml file by adding:

rust-version = "1.81"

?

[Keats]

The issue is that we can still forgot to update it in Cargo.toml except now Cargo will believe it

I don't know how easy it is but if the YAML file from GH actions could read the version from Cargo.toml it would be neat

[fabienbellanger]

Yes, it seems impossible.

In Cargo.toml, add:

rust-version = "1.81"

In ci.yml, change by:

name: ci
on: [push, pull_request]

jobs:
  test_validator:
    name: Continuous integration
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - name: Extract Rust version from Cargo.toml
        run: |
          RUST_VERSION=$(sed -n 's/^rust-version = "\([^"]*\)"/\1/p' Cargo.toml)
          echo "MSRV: $RUST_VERSION"
          echo "RUST_VERSION=$RUST_VERSION" >> $GITHUB_ENV
      - name: Install Rust
        uses: dtolnay/rust-toolchain@stable
        with:
          toolchain: ${{ env.RUST_VERSION }}
      - name: Cache dependencies
        uses: Swatinem/rust-cache@v2
      - name: Build System Info
        run: rustc --version
      - name: Tests
        run: |
          cargo build --no-default-features
          cargo test --no-default-features
          cargo build --features unic --features derive --features card
          cargo test  --features unic --features derive --features card
  test_validator-nightly:
    name: Continuous integration
    runs-on: ubuntu-latest
    strategy:
      matrix:
        include:
          - rust: nightly
    steps:
      - uses: actions/checkout@v3
      - name: Install Rust
        uses: dtolnay/rust-toolchain@stable
        with:
          toolchain: ${{ matrix.rust }}
      - name: Cache dependencies
        uses: Swatinem/rust-cache@v2
      - name: Build System Info
        run: rustc --version
      - name: Tests
        run: |
          cargo build --no-default-features
          cargo test --no-default-features
          cargo build --all-features
          cargo test --all-features

I don't test it on this projet yet, but on another projet, it works like a charm.

[Keats]

Let's try that then!

[Keats]

Nice, thanks