Add support for JWK thumbprints #363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
reviewed
Jan 15, 2024
src/lib.rs
Outdated
| @@ -22,3 +22,7 @@ pub use decoding::{decode, decode_header, DecodingKey, TokenData}; | |||
| pub use encoding::{encode, EncodingKey}; | |||
| pub use header::Header; | |||
| pub use validation::{get_current_timestamp, Validation}; | |||
|
|
|||
| pub use ring::digest::SHA256 as DIGEST_SHA256; | |||
There was a problem hiding this comment.
Let's not expose ring at all. Make an enum with hidden internals and let users use that.
|
Targetted at the ACME/JWS branch here andrewbaxter#1 |
andrewbaxter
force-pushed
the
jwk-thumbprint
branch
from
9709b81 to
8ae98dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datatracker.ietf.org/doc/html/rfc7638
I republished the ring digests so that the feature could be used without matching ring versions.
The thumbprint json is hardcoded templates because I'm not sure if serde_json guarantees json string format (ordering, spacing, etc). The spec is written in such a way that quotation marks and backslashes won't appear in the serialized values so there's no risk of escape issues.
I think the readme's getting a bit crowded, but I didn't want to introduce unrelated changes here so I didn't touch it.
Aside from the unit test, I was testing with letsencrypt/pebble with EC keys and it seemed to be okay (although I switched from serde_json to hardcoded string templates after that).