Update Womersley.py

[keiyamamo]

Hi @hkjeldsberg

We had a new implementation of make_womersley_bc in Womersley.py (@dbruneau-mie’s contribution), where users can directly give Fourier coefficients of the flow rate instead of computing Fourier coefficients based on the specific flow rates. This PR adds such a functionality into VaMPy since we are aiming to use as much functionality as possible from VaMPy.

In addition, there were a few variables that were passed inside the function, but not used (mesh, nu, tmp_area), so I removed them.

I tested the implementation with Artery.py with tiny artery for two cardiac cycles and compared hemodynamics. Since hemodynamics were identical, I assume this implementation should not affect any problem files in VaMPy but would be nice if you could also check.

Please let me know if you have any questions!

Best,
Kei

[hkjeldsberg]

@keiyamamo Looks very good to me! The Womersley script is very outdated and definitely needs some updates. I also think the code contains a lot of commented out code which can be removed, but this can be a minor fix for another time.

Will merge this today 👍

[keiyamamo]

Thanks for merging! I agree it would be nice to clean up the whole script. In general, it is a bit hard to understand what each variable represents and the role of each functions.