Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fruitbar-R2 board. #868

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Add fruitbar-R2 board. #868

wants to merge 34 commits into from

Conversation

newts
Copy link

@newts newts commented Aug 25, 2023

Port of KMK to the fruitbar R2 40% Keyboard with OLED. (the fruitbar has a rotary encoder option which I don't have on mine and did not include here yet).

https://p3dstore.com/products/fruitbar-budget-skeleton-case-and-pcb-group-buy

@xs5871
Copy link
Collaborator

xs5871 commented Aug 28, 2023

There're couple of things the linter isn't happy about.

@newts
Copy link
Author

newts commented Aug 28, 2023

I see. I will fix. can I run the lint on my own? it is just pylint?

@xs5871
Copy link
Collaborator

xs5871 commented Aug 29, 2023

@newts
Copy link
Author

newts commented Sep 3, 2023

I ran black on my files and updated my master. I am not familiar with github pulls if there is more to do. I could not get the test to run on my system (ubuntu).

@xs5871
Copy link
Collaborator

xs5871 commented Sep 4, 2023

I ran black on my files and updated my master. I am not familiar with github pulls if there is more to do. I could not get the test to run on my system (ubuntu).

make devdeps
make test

@newts
Copy link
Author

newts commented Sep 21, 2023

Ok I figured how to run the tests locally and fixed the pylint errors.

jv@Balsamo:~/proj/keebs/fruity-oaty-bar$ make test
.........................................................................
----------------------------------------------------------------------
Ran 73 tests in 4.646s

OK

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a link instead. We won't add pictures or other binary blobs to the repository.

boards/fruitbar/README.md Outdated Show resolved Hide resolved
boards/fruitbar/README.md Outdated Show resolved Hide resolved
boards/fruitbar/README.md Outdated Show resolved Hide resolved
boards/fruitbar/README.md Outdated Show resolved Hide resolved
boards/fruitbar/README.md Outdated Show resolved Hide resolved
Comment on lines 38 to 39
# led_pin = board.pins[11]
# rgb_pixel_pin = board.pins[10]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here? If it's commented out, then it's clearly not needed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

future use, but yes.

Comment on lines +17 to +19
keyboard.SCL = board.GP27
keyboard.SDA = board.GP26

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not part of the keyboard class?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part of the process until I got it to work. yeeting now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I didn't chase it down but these are needed for the OLED to work. I remember when I did this a few months ago I had a hella time figuring out how to configure the OLED.

Is there a better place to define it? There is no circuitpython board defined for it so I found the stamp as the most generic board to use.


from kb import KMKKeyboard

from kmk.extensions.peg_oled_Display import (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recommend you use the display extension instead of peg_oled.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will give it a try.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I don't know what to do here. I used peg_oled as an example and it works. If I change it, what board do you suggest to use as a model?

boards/fruitbar/main.py Outdated Show resolved Hide resolved
boards/fruitbar/main.py Outdated Show resolved Hide resolved
newts and others added 2 commits September 29, 2023 19:06
changes from pr

Co-authored-by: xs5871 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants