-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fruitbar-R2 board. #868
base: master
Are you sure you want to change the base?
Conversation
random typo derp
There're couple of things the linter isn't happy about. |
I see. I will fix. can I run the lint on my own? it is just pylint? |
There's a make command for that: https://github.com/KMKfw/kmk_firmware/blob/master/docs/en/contributing.md#code-style |
I ran black on my files and updated my master. I am not familiar with github pulls if there is more to do. I could not get the test to run on my system (ubuntu). |
make devdeps
make test |
Ok I figured how to run the tests locally and fixed the pylint errors.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a link instead. We won't add pictures or other binary blobs to the repository.
boards/fruitbar/kb.py
Outdated
# led_pin = board.pins[11] | ||
# rgb_pixel_pin = board.pins[10] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this here? If it's commented out, then it's clearly not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
future use, but yes.
keyboard.SCL = board.GP27 | ||
keyboard.SDA = board.GP26 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not part of the keyboard class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
part of the process until I got it to work. yeeting now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I didn't chase it down but these are needed for the OLED to work. I remember when I did this a few months ago I had a hella time figuring out how to configure the OLED.
Is there a better place to define it? There is no circuitpython board defined for it so I found the stamp as the most generic board to use.
|
||
from kb import KMKKeyboard | ||
|
||
from kmk.extensions.peg_oled_Display import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We recommend you use the display
extension instead of peg_oled
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will give it a try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I don't know what to do here. I used peg_oled as an example and it works. If I change it, what board do you suggest to use as a model?
changes from pr Co-authored-by: xs5871 <[email protected]>
for pr Co-authored-by: xs5871 <[email protected]>
pr Co-authored-by: xs5871 <[email protected]>
for PR Co-authored-by: xs5871 <[email protected]>
for PR Co-authored-by: xs5871 <[email protected]>
Co-authored-by: xs5871 <[email protected]>
Co-authored-by: xs5871 <[email protected]>
spelling
fix image to use an external link instead of in repo file.
remove commented code
Port of KMK to the fruitbar R2 40% Keyboard with OLED. (the fruitbar has a rotary encoder option which I don't have on mine and did not include here yet).
https://p3dstore.com/products/fruitbar-budget-skeleton-case-and-pcb-group-buy