Add Piantor to boards #723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regicidalplutophage
approved these changes
Mar 1, 2023
One-Nub
reviewed
Jul 4, 2023
boards/beekeeb/piantor/kb.py
Outdated
|
|
||
| # VBus pin config | ||
| VBUS_PIN = board.VBUS_SENSE # RPi Pico | ||
| # VBUS_PIN = board.GP29 # WeAct RP2040 + resistors on Piantor PCB |
There was a problem hiding this comment.
As a person with the WeAct on a Piantor, board.GP29 results in an error (module has no attribute), it appears as board.A3 instead.
There was a problem hiding this comment.
Thanks! I've updated the comment to board.A3 instead of board.GP29
Correct comment about WeAct RP2040; it should say board.A3 instead of board.GP29 because this pin isn't aliased. Thanks @One-Nub
xs5871
requested changes
Aug 31, 2023
Comment on lines
+10
to
+12
| This firmware assumes that VBUS will be used for split side detection as in the QMK implementation. This requires that the USB cable is plugged into the left side to ensure that the correct pin mapping is used. If using a rp2040 microcontroller without a VBus sense circuit (like the WeAct RP2040), resistors must be soldered to the bottom of the PCBs, and you will need to uncomment line 9 of kb.py to assign the VBus sense pin to GP24. | ||
|
|
||
| An alternative option is to detect the split sides using the drive names. See the [KMK documentation](http://kmkfw.io/docs/split_keyboards#drive-names) for setting this up. Once you have set drive names, you can comment out lines 12-14 and uncomment lines 17-18 in kb.py to enable this option. |
There was a problem hiding this comment.
I think a more robust and universal solution is to check supervisor.runtime.usb_connected.
Comment on lines
+18
to
+19
| data_pin = board.GP1 if split_side == SplitSide.LEFT else board.GP0 | ||
| data_pin2 = board.GP0 if split_side == SplitSide.LEFT else board.GP1 |
There was a problem hiding this comment.
That is what the uart_flip option of the split module is for.
| from kmk.modules.split import Split, SplitSide, SplitType | ||
|
|
||
| keyboard = KMKKeyboard() | ||
| keyboard.tap_time = 100 |
| import digitalio | ||
|
|
||
| from kb import KMKKeyboard, isRight | ||
| from storage import getmount |
| @@ -0,0 +1,63 @@ | |||
| import board | |||
| import digitalio | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.