-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for LED matrix per layer #551
base: master
Are you sure you want to change the base?
Add support for LED matrix per layer #551
Conversation
This either needs linting fixed, or closed if it's superseded by #549 |
I'll fix the linting, going to close the first PR I made now that I have the other two! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok this is awesome and something I wanted in my first version. I am making this comment with my approval just waiting until I can test this to make sure that what peg outputs works with no problems. based on the code I think it works I just want to test it to make sure. I will test tomorrow and report back. Then I can update peg to output the layers.
self.layers = layers if layers else [] | ||
|
||
@staticmethod | ||
def generate_layer(number_of_leds, layer_color): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of these needs removed. Having two methods with the same name is failing the test.
Needs hardware testing, but I believe that's unmangled, and should work. @daysgobye That's your domain. |
Thanks for picking things up, I’ll see if I can take care of the bit that’s making the test fail later tonight! |
No worries. Let me know if I can do anything else for you. Feel free to ping me on Matrix or Discord side of chat if you have any complications. |
Enable triggering different LED matrices for different layers.