-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature analogin #1057
base: feature-analogin
Are you sure you want to change the base?
Feature analogin #1057
Conversation
Added controllable sensitivity tolerance to remove noise from input triggering updates contanly, 1 worked for my sliders but might not for others so they can adjust it but it will cause a "steping" in the input the larger sensitivity value you input
fixed AnalogKeys example, added sensitivity to docs and changed name in code from senstol (tolerance might be better wording not sure..) changed analog in examples to analogInputMap to better match up with keymap.py naming for encoders and what-not added explanation to AnalogKey example to better explain what it does
Added examples for filters, should add more (was kinda think logarithmic for audio perhaps) out of scope but also fixed an issue with midi.py, I think I'm using the most recent copy but for some reason it failed to send the channel when bundled in "message" breaking it out into the call seems to work though also fixed another insistence of AnalogIn when it should be AnalogInputs
I've been writing a wall of text about how this should be more of a backbone for more application-specific modules like MIDI, and now you made a change to midi.py so I hope you provide a good application. Other criticisms is that the The functionality of the Someone has already made a hall effect keyboard with KMK BTW. Other applications may include gamepad with its thumb sticks and shoulder triggers and drawing tablet/digitizer whose coordinates can be derived from the same thumb stick. This applies to #1054 as well obv, but I think that was the point of that draft: "here's an example, if you can apply it, then we can think of merging it." |
Aside from using hall effect sensors to play notes, another way to use this musically would be to use piezo discs as a drum pad. |
Sorry about the change to midi.py |
Yeah, no, my point is that something like that would be the reason to merge, so please, by all means go in that direction. Like, at first your concern was with the minutia of an abstract module, when what it really needs is an application. |
ok I have now learned what an analog multiplexer is lol, kmk just could become a platform to make midi boards quickly and simply if done right. that would be cool. |
It could, but hardware-related features take some effort to assess properly, so contributors have to be willing to provide justification for these features so that KMK won't maintain more code than it has to. Something you can focus on is providing first class support for analog scanners in the MIDI module and documenting these changes. That support would of course rely on that abstract analog module. |
ok so learn then implement scanner to replace and off and on side project of adding to rgb.py for perkey support (side project) so then we are targeting a generalized analog class of key/input method that other extensions/modules can use and emit too (eg midi can receive into the keyboard and change leds or turn them off. common feature on midi boards) |
You know what, hold off on the scanner. I wouldn't feel good about greenlighting it when neither of us can test it with a HE keyboard. Same for demux -- that would also need real hardware first. Just make it so that knobs and sliders are immediately useable with MIDI. |
Got it almost done but didn’t know where to get it’s index from :/ |
Oh Hardware Environment isn’t it should we make a design for a midi board that covers most of the stuff we would need in analog. And if we make it right it could be good enough to sell as “kmk certified” board lol either way I do think there should be more input for a broader use case. Like someone who wants to make midi boards, custom input boards like the xbox accessibility thing.. i think if we did do this though we should look at other possible modules so we could make the ultimate test platform for this just an idea might be kinda to large of an idea but still an idea.. |
Hall Effect, like the one I linked near the beginning of this discussion. That's because in such board analogue scanning is used for actual typing which is the hardest thing to get right and is the ultimate goal.
Ideally, capacity for expansion should be a function of good design. You can come talk in KMK Zulip if you want to discuss more experimental stuff like piezo discs. |
@Maka8295 do you want to upsteam your analogio scanner? |
Hi! I'm very new to GitHub so I'm not sure on these things but yes! Please take what you need from my project :) |
Added sensitivity to reduce noise on inputs making events on mass
Updated and fixed docs to add sensitivity and fix issues with AnalogInputs example