Fix dependency of TapDance on instantiated HoldTap (#1027)

KMKfw · Sep 3, 2024 · deb36a3 · deb36a3
1 parent 57f3ea2
commit deb36a3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/kmk/modules/tapdance.py b/kmk/modules/tapdance.py
@@ -1,4 +1,4 @@
-from kmk.keys import KC, Key, make_argumented_key
+from kmk.keys import Key, make_argumented_key
 from kmk.modules.holdtap import ActivationType, HoldTap, HoldTapKey
 
 
@@ -15,7 +15,7 @@ def __init__(self, *keys, tap_time=None, **kwargs):
 
         for key in keys:
             if not isinstance(key, HoldTapKey):
-                ht_key = KC.HT(
+                ht_key = HoldTapKey(
                     tap=key,
                     hold=key,
                     prefer_hold=True,

diff --git a/tests/test_tapdance.py b/tests/test_tapdance.py
@@ -7,6 +7,17 @@
 from tests.keyboard_test import KeyboardTest
 
 
+class TestTapDanceNoHT(unittest.TestCase):
+    def test(self):
+        KC.clear()
+
+        self.keyboard = KeyboardTest(
+            [TapDance()],
+            [[KC.TD(KC.N0, KC.N1)]],
+            debug_enabled=False,
+        )
+
+
 class TestTapDance(unittest.TestCase):
     def setUp(self):
         self.t_within = 2 * KeyboardTest.loop_delay_ms