Diff view #330

lievenhey · 2021-10-06T13:54:29Z

No description provided.

lievenhey · 2021-10-06T13:57:54Z

lievenhey · 2021-10-06T13:59:13Z

The description of the table is not correct and the data might be a bit crappy

milianw · 2021-10-27T10:33:53Z

The description of the table is not correct and the data might be a bit crappy

is this still open or did you fix it now?

src/diffviewwidget.cpp

src/diffviewwidget.h

src/models/costdelegate.cpp

src/models/data.cpp

milianw · 2021-10-27T10:51:41Z

tests/test-clients/diff-view/slow.cpp

@@ -0,0 +1,22 @@
+void action1()


src/models/diffviewproxy.cpp

src/models/diffviewproxy.h

lievenhey · 2021-11-05T12:40:12Z

I know I still need to update the test files, but the approach taken to create the diff view should be better now.

lievenhey · 2021-11-11T14:09:02Z

I tried adding diffing to the perfparser, but I don't know if this is the right way. Please tell me if the current way is acceptable or if I should try another one.

src/models/data.cpp

src/models/data.h

src/models/diffviewproxy.cpp

src/models/treemodel.cpp

src/mainwindow.h

src/parsers/perf/perfparser.cpp

src/parsers/perf/perfparser.h

src/models/data.cpp

src/parsers/perf/perfparser.cpp

lievenhey · 2021-11-16T14:17:31Z

Still not done, I just wanted to save my progess

src/mainwindow.h

src/mainwindow.cpp

src/models/data.cpp

milianw

nearly done, this is looking really good now, great work and idea with just adding the diff as another cost - I really like that!

src/mainwindow.h

src/mainwindow.cpp

src/models/data.cpp

src/parsers/perf/perfparser.h

src/parsers/perf/perfparser.cpp

src/diffdialog.h

src/diffdialog.cpp

src/models/data.cpp

milianw

can you please squash the patches and add test coverage as well as a meaningful commit message. I would expect a basic summary therein (remember, the What and Why is important):

which part of the perf diff feature set is supported?
what problem does the diffcostproxy solve?
how does on use this new feature?

furthermore, please also add a quick way to diff files from the command line, something like

hotspot --diff perf.data.old perf.data

src/diffreportdialog.cpp

src/mainwindow.cpp

src/models/data.cpp

src/resultsbottomuppage.h

src/models/costproxy.h

src/resultstopdownpage.h

GitMensch · 2022-11-15T09:22:58Z

Other than the missing tests the docs would need an update.
If I knew how to test that locally and there's a CI build providing an AppImage of this I'd give this a test.

GitMensch · 2022-12-13T22:13:38Z

Can you please update the docs (README and possibly a screenshot), too?

lievenhey force-pushed the diff-view branch 2 times, most recently from ed32d25 to 786e577 Compare October 6, 2021 13:56

lievenhey force-pushed the diff-view branch from 786e577 to 65b32ad Compare October 14, 2021 12:46

milianw requested changes Oct 27, 2021

View reviewed changes

lievenhey force-pushed the diff-view branch 4 times, most recently from 23916f1 to 04a1546 Compare November 5, 2021 12:39

lievenhey force-pushed the diff-view branch 3 times, most recently from 8bc5486 to 4f7a309 Compare November 8, 2021 11:14

milianw reviewed Nov 15, 2021

View reviewed changes

src/models/data.cpp Outdated Show resolved Hide resolved

src/models/data.h Outdated Show resolved Hide resolved

src/models/diffviewproxy.cpp Outdated Show resolved Hide resolved

src/models/treemodel.cpp Outdated Show resolved Hide resolved

lievenhey force-pushed the diff-view branch from 6867cd7 to f8304da Compare November 15, 2021 12:28

milianw requested changes Nov 15, 2021

View reviewed changes

lievenhey force-pushed the diff-view branch 2 times, most recently from cd7a4fa to 3752c0a Compare November 16, 2021 14:17

lievenhey force-pushed the diff-view branch from 3752c0a to 3e8f079 Compare November 17, 2021 12:32

milianw requested changes Nov 24, 2021

View reviewed changes

lievenhey force-pushed the diff-view branch from 3e8f079 to daeeccd Compare December 3, 2021 12:50

milianw requested changes Dec 14, 2021

View reviewed changes

src/mainwindow.h Outdated Show resolved Hide resolved

src/mainwindow.cpp Outdated Show resolved Hide resolved

src/models/data.cpp Show resolved Hide resolved

src/parsers/perf/perfparser.h Outdated Show resolved Hide resolved

src/parsers/perf/perfparser.cpp Outdated Show resolved Hide resolved

lievenhey force-pushed the diff-view branch 2 times, most recently from 24193bc to e385487 Compare December 15, 2021 12:32

milianw requested changes Dec 15, 2021

View reviewed changes

src/diffdialog.h Outdated Show resolved Hide resolved

src/diffdialog.cpp Outdated Show resolved Hide resolved

src/models/data.cpp Show resolved Hide resolved

lievenhey force-pushed the diff-view branch from e385487 to 191314e Compare December 17, 2021 13:42

lievenhey requested a review from milianw September 15, 2022 12:24

lievenhey force-pushed the diff-view branch 3 times, most recently from 3884c11 to 6833b8d Compare September 15, 2022 12:49

lievenhey force-pushed the diff-view branch 2 times, most recently from b38eb4e to 299ae5c Compare September 26, 2022 12:02

milianw requested changes Sep 30, 2022

View reviewed changes

lievenhey force-pushed the diff-view branch from 299ae5c to edc13e6 Compare November 16, 2022 15:12

lievenhey marked this pull request as ready for review November 16, 2022 15:13

lievenhey force-pushed the diff-view branch 6 times, most recently from 7e57a77 to 8f94380 Compare November 18, 2022 16:06

lievenhey force-pushed the diff-view branch 3 times, most recently from f73e0ef to ce85f08 Compare December 8, 2022 12:30

lievenhey requested a review from milianw December 8, 2022 12:31

lievenhey force-pushed the diff-view branch 4 times, most recently from 50599ac to c0c01a5 Compare December 8, 2022 15:32

lievenhey added 3 commits December 8, 2022 16:36

diff gui

968ebf3

add proxy to calculate diff costs

e207ac4

diff view for top down and bottom up

e0b8957

lievenhey force-pushed the diff-view branch from c0c01a5 to e0b8957 Compare December 8, 2022 15:37

lievenhey marked this pull request as draft September 19, 2023 14:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Diff view #330

Diff view #330

lievenhey commented Oct 6, 2021

lievenhey commented Oct 6, 2021

lievenhey commented Oct 6, 2021 •

edited

milianw commented Oct 27, 2021

milianw Oct 27, 2021

lievenhey commented Nov 5, 2021

lievenhey commented Nov 11, 2021

lievenhey commented Nov 16, 2021

milianw left a comment

milianw left a comment

GitMensch commented Nov 15, 2022

GitMensch commented Dec 13, 2022

Diff view #330

Are you sure you want to change the base?

Diff view #330

Conversation

lievenhey commented Oct 6, 2021

lievenhey commented Oct 6, 2021

lievenhey commented Oct 6, 2021 • edited

milianw commented Oct 27, 2021

milianw Oct 27, 2021

Choose a reason for hiding this comment

lievenhey commented Nov 5, 2021

lievenhey commented Nov 11, 2021

lievenhey commented Nov 16, 2021

milianw left a comment

Choose a reason for hiding this comment

milianw left a comment

Choose a reason for hiding this comment

GitMensch commented Nov 15, 2022

GitMensch commented Dec 13, 2022

lievenhey commented Oct 6, 2021 •

edited