Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disassembly view: provide a way to find hotspots (local/incl.) faster #528

Open
GitMensch opened this issue Oct 13, 2023 · 2 comments
Open

Comments

@GitMensch
Copy link
Contributor

The very interesting option in kcachegrind (which is also the reason that the assembly view has a source reference) is that one can order by clicking on the columns, enabling you to order by costs (this way seeing "local" hotpots very fast), click on an interesting line to mark it, then order by line (source view) / address (disassembly), then use arrow-up to position on the line before the one you've marked before.

Originally posted by @GitMensch in #523 (comment)

@milianw
Copy link
Member

milianw commented Oct 22, 2023

I'm opposed to this idea - reordering based on cost in the source and assembly views leads to pretty confusing results.

if the problem is finding "local" hotspots faster, then I propose we follow vtune and it's controls to cycle through the hotspots in descending order. i.e. a simple button that starts at the top hotspot and then goes to the next hotspot and so forth before it wrap-arounds.

@GitMensch GitMensch changed the title Disassembly view: allow to order by columns Disassembly view: provide a way to find hotspots (local/incl.) faster Oct 22, 2023
@GitMensch
Copy link
Contributor Author

I have never used vtune so far, but I totally agree that an option to find skip through the hotspots (possibly by decreasing cost) would be much ore useful.
This should be available for both "real local" and "inclusive" costs.

Your idea - which is definitely better - sounds good, but I fear that this would:

  • need design decisions (how should the feature be accessed, how to switch between "local" and "inclusive")
  • need an internal linked list ordered by costs
  • needs a bunch of code and therefore new tests
  • summary: may need quite some time to arrive

The column ordering seems to get down to just allowing to order by those columns - setting an attribute only.
To be "less confusing" I'd suggest to always set the default ordering (by first column = line/address) when the view is opened (new disassembly chosen).

What do you think about making the columns able to sort for now, keeping that until the much more "vtune-like" feature arrives?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants