Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disassembly view: add "go to line/address" command #541

Closed
GitMensch opened this issue Oct 25, 2023 · 5 comments · Fixed by #573
Closed

Disassembly view: add "go to line/address" command #541

GitMensch opened this issue Oct 25, 2023 · 5 comments · Fixed by #573

Comments

@GitMensch
Copy link
Contributor

GitMensch commented Oct 25, 2023

Is your feature request related to a problem? Please describe.
I've recognized that I often "scroll around" to switch between several parts of a function. So far it is necessary to remind the place in the horizontal scroll bar, then get back using this (or use the new search feature).

Describe the solution you'd like
The easiest option to "skip around" would be a general-use function "go to", ideally with the default shortcut CTRL+G (in the "active" window, like it is done for CTRL+F).

Additional context
As there may not be the exact line, and especially not the exact address: position to the first line after the specified one, if there isn't one then position to the last.

Additional to the general usability it would also provide a workaround for #515.

@lievenhey
Copy link
Contributor

lievenhey commented Dec 5, 2023

You can click on a line to go to the corresponding one in the other view (only those with a colored background work).

@lievenhey
Copy link
Contributor

Waht do you mean by "go to function"? Enter an address and jump there? Or something like: put a marker here and then some shortcuts to jump between markers?

@GitMensch
Copy link
Contributor Author

GitMensch commented Dec 5, 2023

On the right:

both seem easy - but I have no clue how to do that.

Nonetheless, your idea of "adding favorite points to fast switch between" is also good, you may want to create a separate issue for that.

But #528 seems to be much more useful than the favorites and may be implemented first.

@GitMensch
Copy link
Contributor Author

GitMensch commented Dec 12, 2023

@lievenhey is there any chance for you to tackle this and/or #515 next?

@lievenhey
Copy link
Contributor

sure

lievenhey added a commit that referenced this issue Dec 12, 2023
this allows to user to quickly jump to a location without scrolling

closes: #541
@lievenhey lievenhey linked a pull request Dec 12, 2023 that will close this issue
lievenhey added a commit that referenced this issue Jan 9, 2024
this allows to user to quickly jump to a location without scrolling

closes: #541
lievenhey added a commit that referenced this issue Jan 9, 2024
this allows to user to quickly jump to a location without scrolling

closes: #541
lievenhey added a commit that referenced this issue Jan 9, 2024
this allows to user to quickly jump to a location without scrolling

closes: #541
lievenhey added a commit that referenced this issue Jan 9, 2024
this allows to user to quickly jump to a location without scrolling

closes: #541
lievenhey added a commit that referenced this issue Jan 12, 2024
this allows to user to quickly jump to a location without scrolling

closes: #541
lievenhey added a commit that referenced this issue Jan 12, 2024
this allows to user to quickly jump to a location without scrolling

closes: #541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants