Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules for routingbot-IGP #974

Open
wants to merge 8 commits into
base: jcloud
Choose a base branch
from
Open

rules for routingbot-IGP #974

wants to merge 8 commits into from

Conversation

vsg26
Copy link

@vsg26 vsg26 commented Sep 6, 2024

I have added 8 rule files which needs to be added for routingbot. Also tested the same using Paragon Insights APIs.

@healthbot-ci
Copy link
Collaborator

Only Juniper employees can contribute to juniper_official folder. If you are one follow the steps mentioned in the README else, contribute to the community_supplied directory. Make the necessary changes and commit again.

@vsg26
Copy link
Author

vsg26 commented Sep 10, 2024

Link for requirement: https://paragon-automation.atlassian.net/browse/REQ-1349

@vvikramb
Copy link
Collaborator

1.collect-isis-counters rule, the field name is level-num but in collect-isis-lsdb-lsp it is level-numb, please keep naming constant across all rules.
2.collect-isis-lsdb-neighbsysid has maultiple keys ( instance-name protocol-name level-num lsp-id tlv-value neighb-sysid ), can this be reduced?
3.Add the requirement number if available for all rules.
4.collect-isis-lsdb-subtlv rule also has 7 keys, please reduce the number of keys.Check for all rules.

juniper_official/routing/collect-isis-counters.rule Outdated Show resolved Hide resolved
juniper_official/routing/collect-isis-counters.rule Outdated Show resolved Hide resolved
supported-devices {
juniper {
operating-system junos {
products MX {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we supporting only MX960. Please make sure all the models are added here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently supporting only for MX960 and will be adding other platforms in testing phase.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that RB will not be instantiating this rule for any other models?

juniper_official/routing/collect-isis-lsdb-lsp.rule Outdated Show resolved Hide resolved
juniper_official/routing/collect-isis-lsp-retranx.rule Outdated Show resolved Hide resolved
juniper_official/routing/collect-isis-lsp-retranx.rule Outdated Show resolved Hide resolved
juniper_official/routing/collect-isis-lsp-retranx2.rule Outdated Show resolved Hide resolved
juniper_official/routing/collect-isis-lsp-retranx2.rule Outdated Show resolved Hide resolved
juniper_official/routing/collect-isis-lsp-retranx2.rule Outdated Show resolved Hide resolved
*/
healthbot {
topic routing.isis {
rule collect-isis-lsdb-neighbsysid-v1 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is v1 and v2 in the rule names?

*/
healthbot {
topic routing.isis {
rule collect-isis-lsp-retranx-v1 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why v1 and v2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants