Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix power rules to fix some of the broken tests in CAS #252

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

gkronber
Copy link
Collaborator

Bugfix in diff(x^n, x) rule and prevent folding 0^0 as well as negative to non-integer power

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.25%. Comparing base (e9aefa6) to head (5e5e912).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           ale/3.0     #252      +/-   ##
===========================================
+ Coverage    81.12%   81.25%   +0.13%     
===========================================
  Files           18       18              
  Lines         1499     1499              
===========================================
+ Hits          1216     1218       +2     
+ Misses         283      281       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 10, 2024

Benchmark Results

egg-sym egg-cust MT@5e5e912b86c... MT@e9aefa6e6ea... egg-sym/MT@5e5... egg-cust/MT@5e... MT@e9aefa6e6ea...
egraph_addexpr 1.45 ms 5.12 ms 5.12 ms 0.283 1
basic_maths_simpl2 12.5 ms 5 ms 19.3 ms 19.2 ms 0.648 0.259 0.995
prop_logic_freges_theorem 2.49 ms 1.53 ms 1.04 ms 1.04 ms 2.4 1.47 1
calc_logic_demorgan 61.1 μs 34.8 μs 74.7 μs 74.9 μs 0.817 0.465 1
calc_logic_freges_theorem 21.6 ms 11.8 ms 41 ms 40.9 ms 0.527 0.287 0.999
basic_maths_simpl1 6 ms 2.75 ms 4.68 ms 4.56 ms 1.28 0.589 0.975
egraph_constructor 0.0818 μs 0.0901 μs 0.0893 μs 0.907 0.99
prop_logic_prove1 34.7 ms 13.7 ms 41.2 ms 40.2 ms 0.841 0.332 0.974
prop_logic_demorgan 79.2 μs 44.2 μs 94 μs 93.5 μs 0.843 0.47 0.995
while_superinterpreter_while_10 18 ms 18.2 ms 1.01
prop_logic_rewrite 121 μs 120 μs 0.992
time_to_load 113 ms 113 ms 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@gkronber gkronber marked this pull request as ready for review October 11, 2024 05:55
@0x0f0f0f 0x0f0f0f merged commit 6814104 into ale/3.0 Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants