Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutable semantic analysis (data) for eclass #250

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

gkronber
Copy link
Collaborator

@gkronber gkronber commented Oct 5, 2024

Allow to update data field of eclasses to simplify code and remove the need to allocate new eclass objects when two eclasses are merged.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.18%. Comparing base (081a9e6) to head (ff76202).

Files with missing lines Patch % Lines
src/EGraphs/egraph.jl 85.71% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           ale/3.0     #250      +/-   ##
===========================================
+ Coverage    81.17%   81.18%   +0.01%     
===========================================
  Files           19       19              
  Lines         1503     1504       +1     
===========================================
+ Hits          1220     1221       +1     
  Misses         283      283              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 5, 2024

Benchmark Results

egg-sym egg-cust MT@ff76202ce39... MT@081a9e6f07d... egg-sym/MT@ff7... egg-cust/MT@ff... MT@081a9e6f07d...
egraph_addexpr 1.47 ms 4.99 ms 4.99 ms 0.296 0.999
basic_maths_simpl2 12.7 ms 5.1 ms 19.8 ms 19.8 ms 0.64 0.257 0.998
prop_logic_freges_theorem 2.53 ms 1.55 ms 1.05 ms 1.05 ms 2.39 1.47 1
calc_logic_demorgan 60.4 μs 35 μs 73.9 μs 75.7 μs 0.818 0.473 1.03
calc_logic_freges_theorem 21.9 ms 12.4 ms 42 ms 41.6 ms 0.522 0.296 0.99
basic_maths_simpl1 6.03 ms 2.81 ms 4.68 ms 4.66 ms 1.29 0.6 0.996
egraph_constructor 0.0871 μs 0.0917 μs 0.092 μs 0.949 1
prop_logic_prove1 35.1 ms 13.9 ms 40.4 ms 41.7 ms 0.869 0.345 1.03
prop_logic_demorgan 80 μs 45 μs 93.3 μs 94 μs 0.857 0.483 1.01
while_superinterpreter_while_10 18.3 ms 18.4 ms 1
prop_logic_rewrite 121 μs 120 μs 0.992
time_to_load 114 ms 114 ms 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@gkronber
Copy link
Collaborator Author

gkronber commented Oct 8, 2024

No effect on benchmark results.

@gkronber gkronber marked this pull request as ready for review October 8, 2024 11:11
@0x0f0f0f 0x0f0f0f merged commit e9aefa6 into ale/3.0 Oct 10, 2024
4 checks passed
@gkronber gkronber deleted the mutable_eclass branch October 11, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants