Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings in tests #1894

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Fix deprecation warnings in tests #1894

merged 6 commits into from
Sep 25, 2024

Conversation

devmotion
Copy link
Member

#1893 seems to cause a few deprecation warnings in our tests. This PR tries to fix them.

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.99%. Comparing base (b219803) to head (2b34462).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1894   +/-   ##
=======================================
  Coverage   85.99%   85.99%           
=======================================
  Files         144      144           
  Lines        8666     8669    +3     
=======================================
+ Hits         7452     7455    +3     
  Misses       1214     1214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devmotion devmotion marked this pull request as ready for review September 23, 2024 12:00
@devmotion devmotion merged commit 61b64b8 into master Sep 25, 2024
15 checks passed
@devmotion devmotion deleted the dw/deprecations branch September 25, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants