Respect type of parameters in fit
for Bernoulli
, Binomial
, and Uniform
#1558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #1551 and #1557, this PR addresses #1544 for
Bernoulli
,Binomial
, andUniform
.With this PR
fit(Uniform{Float32}, ...)
etc. will actually estimate a distribution of typeUniform{Float32}
, regardless of the observations. One can still usefit(Uniform, ...)
if the parameter type should not be fixed but depend on the type of the observations.