Provide errorbars as callable recipes #4362

BeastyBlacksmith · 2022-09-21T08:06:10Z

This is the implementation of #4360 (comment), which should work whether or not we are going with #4360, IMO.

github-actions · 2022-09-21T08:23:26Z

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Time of benchmarks:
- Target: 21 Sep 2022 - 08:20
- Baseline: 21 Sep 2022 - 08:23
Package commits:
- Target: 9ade71
- Baseline: ef4a7a
Julia commits:
- Target: 742b9a
- Baseline: 742b9a
Julia command flags:
- Target: None
- Baseline: None
Environment variables:
- Target: None
- Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["display"]`	0.00 (5%) ✅	0.00 (1%) ✅
`["load_plot_display"]`	0.95 (5%)	0.00 (1%) ✅
`["plot"]`	0.71 (5%) ✅	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

[]

Julia versioninfo

Target

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1019-azure #24~20.04.1-Ubuntu SMP Tue Aug 23 15:52:52 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2397 MHz       2647 s          2 s        248 s       3040 s          0 s
       #2  2397 MHz       1765 s          1 s        284 s       3897 s          0 s
       
  Memory: 6.78125 GB (2705.65234375 MB free)
  Uptime: 601.06 sec
  Load Avg:  0.99  0.92  0.47
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, haswell)

Baseline

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1019-azure #24~20.04.1-Ubuntu SMP Tue Aug 23 15:52:52 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2397 MHz       3476 s          2 s        262 s       3631 s          0 s
       #2  2397 MHz       2353 s          1 s        298 s       4728 s          0 s
       
  Memory: 6.78125 GB (2634.85546875 MB free)
  Uptime: 744.72 sec
  Load Avg:  1.0  0.96  0.56
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, haswell)

Target result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Time of benchmark: 21 Sep 2022 - 8:20
Package commit: 9ade71
Julia commit: 742b9a
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	memory	allocations
`["display"]`	4.405 ms (5%)	244.67 KiB (1%)	4420
`["load"]`	4.264 s (5%)	4.70 KiB (1%)	91
`["load_plot_display"]`	20.412 s (5%)	4.75 KiB (1%)	91
`["plot"]`	626.426 μs (5%)	79.62 KiB (1%)	1438

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

[]

Julia versioninfo

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1019-azure #24~20.04.1-Ubuntu SMP Tue Aug 23 15:52:52 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2397 MHz       2647 s          2 s        248 s       3040 s          0 s
       #2  2397 MHz       1765 s          1 s        284 s       3897 s          0 s
       
  Memory: 6.78125 GB (2705.65234375 MB free)
  Uptime: 601.06 sec
  Load Avg:  0.99  0.92  0.47
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, haswell)

Baseline result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Time of benchmark: 21 Sep 2022 - 8:23
Package commit: ef4a7a
Julia commit: 742b9a
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["display"]`	10.886 s (5%)	425.429 ms	1000.38 MiB (1%)	18303229
`["load"]`	4.355 s (5%)		4.70 KiB (1%)	91
`["load_plot_display"]`	21.428 s (5%)	15.100 ms	22.67 MiB (1%)	425671
`["plot"]`	887.141 μs (5%)		79.62 KiB (1%)	1438

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

[]

Julia versioninfo

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1019-azure #24~20.04.1-Ubuntu SMP Tue Aug 23 15:52:52 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz: 
              speed         user         nice          sys         idle          irq
       #1  2397 MHz       3476 s          2 s        262 s       3631 s          0 s
       #2  2397 MHz       2353 s          1 s        298 s       4728 s          0 s
       
  Memory: 6.78125 GB (2634.85546875 MB free)
  Uptime: 744.72 sec
  Load Avg:  1.0  0.96  0.56
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, haswell)

Runtime information

Runtime Info
BLAS #threads	2
`BLAS.vendor()`	`openblas64`
`Sys.CPU_THREADS`	2

lscpu output:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          2
On-line CPU(s) list:             0,1
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           63
Model name:                      Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Stepping:                        2
CPU MHz:                         2397.217
BogoMIPS:                        4794.43
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       64 KiB
L1i cache:                       64 KiB
L2 cache:                        512 KiB
L3 cache:                        30 MiB
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     KVM: Mitigation: VMX unsupported
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Mmio stale data:   Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed:          Not affected
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, STIBP disabled, RSB filling
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Not affected
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear

Cpu Property	Value
Brand	Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
Vendor	:Intel
Architecture	:Haswell
Model	Family: 0x06, Model: 0x3f, Stepping: 0x02, Type: 0x00
Cores	2 physical cores, 2 logical cores (on executing CPU)
	No Hyperthreading hardware capability detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 256, 30720) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 46 bits physical
SIMD	256 bit = 32 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via `rdtsc`
	TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

github-actions · 2022-09-21T08:38:17Z

Benchmark result

Judge result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Time of benchmarks:
- Target: 21 Sep 2022 - 08:35
- Baseline: 21 Sep 2022 - 08:37
Package commits:
- Target: 1224b8
- Baseline: ef4a7a
Julia commits:
- Target: 742b9a
- Baseline: 742b9a
Julia command flags:
- Target: None
- Baseline: None
Environment variables:
- Target: None
- Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["display"]`	0.00 (5%) ✅	0.00 (1%) ✅
`["load_plot_display"]`	0.95 (5%)	0.00 (1%) ✅
`["plot"]`	0.81 (5%) ✅	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

[]

Julia versioninfo

Target

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1019-azure #24~20.04.1-Ubuntu SMP Tue Aug 23 15:52:52 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz       2124 s          2 s        250 s       2987 s          0 s
       #2  2095 MHz       1938 s          1 s        257 s       3161 s          0 s
       
  Memory: 6.781253814697266 GB (2629.4921875 MB free)
  Uptime: 544.13 sec
  Load Avg:  1.25  1.03  0.51
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1019-azure #24~20.04.1-Ubuntu SMP Tue Aug 23 15:52:52 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz       3096 s          2 s        266 s       3260 s          0 s
       #2  2095 MHz       2211 s          1 s        271 s       4132 s          0 s
       
  Memory: 6.781253814697266 GB (2617.046875 MB free)
  Uptime: 670.22 sec
  Load Avg:  1.06  1.03  0.59
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Target result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Time of benchmark: 21 Sep 2022 - 8:35
Package commit: 1224b8
Julia commit: 742b9a
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	memory	allocations
`["display"]`	4.150 ms (5%)	244.67 KiB (1%)	4420
`["load"]`	3.986 s (5%)	4.70 KiB (1%)	91
`["load_plot_display"]`	18.146 s (5%)	4.75 KiB (1%)	91
`["plot"]`	614.507 μs (5%)	79.62 KiB (1%)	1438

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

[]

Julia versioninfo

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1019-azure #24~20.04.1-Ubuntu SMP Tue Aug 23 15:52:52 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz       2124 s          2 s        250 s       2987 s          0 s
       #2  2095 MHz       1938 s          1 s        257 s       3161 s          0 s
       
  Memory: 6.781253814697266 GB (2629.4921875 MB free)
  Uptime: 544.13 sec
  Load Avg:  1.25  1.03  0.51
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Baseline result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Time of benchmark: 21 Sep 2022 - 8:37
Package commit: ef4a7a
Julia commit: 742b9a
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["display"]`	9.639 s (5%)	362.086 ms	1000.79 MiB (1%)	18311532
`["load"]`	4.002 s (5%)		4.70 KiB (1%)	91
`["load_plot_display"]`	19.021 s (5%)	12.428 ms	22.67 MiB (1%)	425672
`["plot"]`	754.707 μs (5%)		79.62 KiB (1%)	1438

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

[]

Julia versioninfo

Julia Version 1.7.3
Commit 742b9abb4d (2022-05-06 12:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      Ubuntu 20.04.5 LTS
  uname: Linux 5.15.0-1019-azure #24~20.04.1-Ubuntu SMP Tue Aug 23 15:52:52 UTC 2022 x86_64 x86_64
  CPU: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz: 
              speed         user         nice          sys         idle          irq
       #1  2095 MHz       3096 s          2 s        266 s       3260 s          0 s
       #2  2095 MHz       2211 s          1 s        271 s       4132 s          0 s
       
  Memory: 6.781253814697266 GB (2617.046875 MB free)
  Uptime: 670.22 sec
  Load Avg:  1.06  1.03  0.59
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-12.0.1 (ORCJIT, skylake-avx512)

Runtime information

Runtime Info
BLAS #threads	2
`BLAS.vendor()`	`openblas64`
`Sys.CPU_THREADS`	2

lscpu output:

Architecture:                    x86_64
CPU op-mode(s):                  32-bit, 64-bit
Byte Order:                      Little Endian
Address sizes:                   46 bits physical, 48 bits virtual
CPU(s):                          2
On-line CPU(s) list:             0,1
Thread(s) per core:              1
Core(s) per socket:              2
Socket(s):                       1
NUMA node(s):                    1
Vendor ID:                       GenuineIntel
CPU family:                      6
Model:                           85
Model name:                      Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Stepping:                        4
CPU MHz:                         2095.073
BogoMIPS:                        4190.14
Hypervisor vendor:               Microsoft
Virtualization type:             full
L1d cache:                       64 KiB
L1i cache:                       64 KiB
L2 cache:                        2 MiB
L3 cache:                        35.8 MiB
NUMA node0 CPU(s):               0,1
Vulnerability Itlb multihit:     KVM: Mitigation: VMX unsupported
Vulnerability L1tf:              Mitigation; PTE Inversion
Vulnerability Mds:               Mitigation; Clear CPU buffers; SMT Host state unknown
Vulnerability Meltdown:          Mitigation; PTI
Vulnerability Mmio stale data:   Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown
Vulnerability Retbleed:          Vulnerable
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1:        Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:        Mitigation; Retpolines, STIBP disabled, RSB filling
Vulnerability Srbds:             Not affected
Vulnerability Tsx async abort:   Mitigation; Clear CPU buffers; SMT Host state unknown
Flags:                           fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear

Cpu Property	Value
Brand	Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
Vendor	:Intel
Architecture	:Skylake
Model	Family: 0x06, Model: 0x55, Stepping: 0x04, Type: 0x00
Cores	2 physical cores, 2 logical cores (on executing CPU)
	No Hyperthreading hardware capability detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 1024, 36608) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 46 bits physical
SIMD	512 bit = 64 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via `rdtsc`
	TSC increased at every clock cycle (non-invariant TSC)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

codecov · 2022-09-21T08:55:37Z

Codecov Report

Base: 80.54% // Head: 80.57% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (443a6a4) compared to base (ef4a7a6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4362      +/-   ##
==========================================
+ Coverage   80.54%   80.57%   +0.02%     
==========================================
  Files          28       28              
  Lines        7316     7319       +3     
==========================================
+ Hits         5893     5897       +4     
+ Misses       1423     1422       -1

Impacted Files	Coverage Δ
src/shorthands.jl	`96.15% <ø> (ø)`
src/pipeline.jl	`95.33% <100.00%> (+0.44%)`	⬆️
src/recipes.jl	`67.78% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

BeastyBlacksmith added 2 commits September 21, 2022 10:13

export (x/y/z)error(!)

e0f61fe

let markershape be overrideble

186a961

BeastyBlacksmith force-pushed the bbs/errors branch from be6401f to 186a961 Compare September 21, 2022 08:13

BeastyBlacksmith mentioned this pull request Sep 21, 2022

Customize errorbars (in particular their caps) #2156

Open

more specific condition

443a6a4

BeastyBlacksmith merged commit cf1a0c2 into master Sep 21, 2022

BeastyBlacksmith deleted the bbs/errors branch September 21, 2022 11:13

BeastyBlacksmith mentioned this pull request Oct 27, 2022

Errorbar caps following markershape problematic #4476

Closed

Provide errorbars as callable recipes #4362

Provide errorbars as callable recipes #4362

Conversation

BeastyBlacksmith commented Sep 21, 2022

github-actions bot commented Sep 21, 2022

Judge result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Runtime information

github-actions bot commented Sep 21, 2022

Judge result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/Plots.jl/Plots.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Runtime information

codecov bot commented Sep 21, 2022 • edited Loading

Codecov Report

codecov bot commented Sep 21, 2022 •

edited

Loading