Allow 2d coordinates for heatmap plots in PyPlot backend #4298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows plotting on a non-rectangular grid, at least with PyPlot backend. For example:
produces
Currently 'Draft' because:
_heatmap_edges()
is fudged for 2dx
andy
. PyPlot can handle the cell-centre/cell-edge conversion automatically so the_heatmap_edges()
functionality is not needed for the case I was trying to get working. It would be nicer to be more general, but the logic is a bit more complicated (I guess an extra argument would need to be passed to say which dimension needs to be converted from centres to edges?) - is it worth doing and does anyone have opinions/suggestions on the best way?z
being transposed. I got lost trying to look for where a special-case for 2dx
andy
would be needed though... Should only backends where 2dx
andy
are known to work be supported? If so where would be a good place to throw an error for unsupported backends?Maybe an expert can see a better way to implement this and would find it easier to start from scratch, in which case please consider this just a feature request!