-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rsqrt function and test cases #268
base: master
Are you sure you want to change the base?
Add rsqrt function and test cases #268
Conversation
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
========================================
Coverage ? 82.5%
========================================
Files ? 25
Lines ? 1229
Branches ? 0
========================================
Hits ? 1014
Misses ? 215
Partials ? 0
Continue to review full report at Codecov.
|
I'm not sure that |
Actually the function is there with the same name in the document as well in octave. The implementation should give the tighest interval. |
In the standard it appears as I agree with David that Independently of the name, one more suggestion: add docstrings and also an entry into the documentation. |
Ok, I'll change the name and do the suggested. |
9ee216c
to
0b45a07
Compare
Any progress on this? |
Yeah I have changed the name and added a doc string. You can review it. |
Could you please rebase? |
0b45a07
to
d8b8ac0
Compare
d8b8ac0
to
5b302fb
Compare
Adding rsqrt function from Recommended Elementary function.