-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for FileIO #35
Conversation
@ashwani-rathee |
@ashwani-rathee Gentle bump |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
============================================
- Coverage 100.00% 18.75% -81.25%
============================================
Files 1 3 +2
Lines 1 32 +31
============================================
+ Hits 1 6 +5
- Misses 0 26 +26 ☔ View full report in Codecov by Sentry. |
@rakeshksr Would you be able to update this package and get these PRs merged. I am happy to give you commit access if you have the time to refresh the package. EDIT: Never mind - it seems like you already have commit. |
@ViralBShah I would be pleased to contribute to the merging of this pr. |
@rakeshksr What is the next step? CI seems to be passing. If ready, please do merge and tag a new release. That'll be wonderful. I think the FileIO side of the PR is already merged. |
@ViralBShah Integration with the visualization packages like Plots.jl, Makie.jl and seamless interpolation with Images.jl ecosystem would be highly beneficial. |
@rakeshksr Sent you invite to have commit access to JuliaImages |
@ViralBShah successfully joined in JuliaImages organization, but invitation to OpenCV.jl showing following error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great to see efforts made to OpenCV.jl
@rakeshksr I added you to this repo then cancelled that invite and sent a second invite that was for the whole organization. Did you receice a second email? EDIT:I see you accepted it and are in the organization. |
@ViralBShah I am still awaiting the necessary write access to this repository, which is currently blocking the merge of this pull request. |
I see what happened. Try now. I gave JuliaImages/Committers |
Is this something we need to mention in the README or elsewhere in some docs? |
Docs are already committed to this PR. |
This PR adds support for FileIO.jl and
Base.show
method forOpenCV.Mat
format.Awaiting JuliaIO/FileIO.jl#381 to merge.
Covers most of #34.
Closes #30 .