Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for FileIO #35

Merged
merged 9 commits into from
Oct 28, 2024
Merged

Conversation

rakeshksr
Copy link
Member

This PR adds support for FileIO.jl and Base.show method for OpenCV.Mat format.
Awaiting JuliaIO/FileIO.jl#381 to merge.
Covers most of #34.
Closes #30 .

@rakeshksr
Copy link
Member Author

Image preview working fine Pluto.jl, Ijulia and VS Code.

VS Code

vscode

Pluto.jl

pluto

IJulia

ijulia

@rakeshksr rakeshksr marked this pull request as ready for review January 4, 2024 11:40
@rakeshksr
Copy link
Member Author

@ashwani-rathee
The PR JuliaIO/FileIO.jl#381, which this PR relied on, has been successfully merged. With that dependency out of the way, I'd be grateful if you could take a look at this PR

@rakeshksr
Copy link
Member Author

@ashwani-rathee Gentle bump

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 16.12903% with 26 lines in your changes missing coverage. Please review.

Project coverage is 18.75%. Comparing base (ccc99cc) to head (dd98c04).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/fileio.jl 17.85% 23 Missing ⚠️
src/show.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##            master      #35       +/-   ##
============================================
- Coverage   100.00%   18.75%   -81.25%     
============================================
  Files            1        3        +2     
  Lines            1       32       +31     
============================================
+ Hits             1        6        +5     
- Misses           0       26       +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Contributor

ViralBShah commented Oct 13, 2024

@rakeshksr Would you be able to update this package and get these PRs merged. I am happy to give you commit access if you have the time to refresh the package.

EDIT: Never mind - it seems like you already have commit.

@rakeshksr
Copy link
Member Author

@ViralBShah I would be pleased to contribute to the merging of this pr.

@ViralBShah
Copy link
Contributor

ViralBShah commented Oct 26, 2024

@rakeshksr What is the next step? CI seems to be passing. If ready, please do merge and tag a new release. That'll be wonderful. I think the FileIO side of the PR is already merged.

@rakeshksr
Copy link
Member Author

@ViralBShah Integration with the visualization packages like Plots.jl, Makie.jl and seamless interpolation with Images.jl ecosystem would be highly beneficial.
FileIO side of the PR is already merged in JuliaIO/FileIO.jl#381.
I don't have sufficient permissions to commit changes to this repository.

@ViralBShah
Copy link
Contributor

@rakeshksr Sent you invite to have commit access to JuliaImages

@rakeshksr
Copy link
Member Author

@ViralBShah successfully joined in JuliaImages organization, but invitation to OpenCV.jl showing following error
image
I would be grateful if you could re-authorize write access to this repository.

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to see efforts made to OpenCV.jl

@ViralBShah
Copy link
Contributor

ViralBShah commented Oct 28, 2024

@rakeshksr I added you to this repo then cancelled that invite and sent a second invite that was for the whole organization. Did you receice a second email?

EDIT:I see you accepted it and are in the organization.

@rakeshksr
Copy link
Member Author

@ViralBShah I am still awaiting the necessary write access to this repository, which is currently blocking the merge of this pull request.

image

@ViralBShah
Copy link
Contributor

I see what happened. Try now. I gave JuliaImages/Committers maintain access on various repos in the org now.

@rakeshksr rakeshksr merged commit 34dcb51 into JuliaImages:master Oct 28, 2024
7 of 9 checks passed
@ViralBShah
Copy link
Contributor

Is this something we need to mention in the README or elsewhere in some docs?

@rakeshksr
Copy link
Member Author

Docs are already committed to this PR.
https://juliaimages.org/OpenCV.jl/dev/Getting%20started%20with%20Images/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Base.show for OpenCV.Mat image
3 participants