Have two set of fields #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojukka5
force-pushed
the
ahojukka5/fix_interpolation_performance
branch
2 times, most recently
from
0147d38
to
9b15470
Compare
ahojukka5
force-pushed
the
ahojukka5/fix_interpolation_performance
branch
from
9983eca
to
71af1ed
Compare
We get some bad ideas, like writing own `size` and `length`. We should get rid of them in some time, thus moved to `depreacted.jl`.
Declar new abstract type AbstractElement and modify functions so that they take AbstractElement as input argument. This change allows to define new elements with different properties, in principle. However most of the functions are heavily related to existing structure of the Element.
About 25 ns to 20 ns by changing comparison. I also noted that interpolation when time is `Inf` or `-Inf` is significantly faster, only 7 ns, so for fast access for first or last time frame, maybe consider that.
Avoid type confusion by having a type for a field. After all, it's a field and ::AbstractField is thus justified.
This is the first step to implement statically typed fields. Let's make room for the implementation by renaming old fields to dfields and also make the code in elements.jl to be more clear. Lot of stuff moved to deprecated.jl.
This is going to be a part of documentation using Literate.jl
ahojukka5
force-pushed
the
ahojukka5/fix_interpolation_performance
branch
from
71af1ed
to
be5f52d
Compare
Declaring elements without connectivity vector/tuple at all is probably a bad idea. Better idea is to define right size vector describing connectivity, but give zeros to those nodes which are not connected to anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new type of set of fields, which must be defined and initialized when creating a new element. Closes issue #47. It is now well-known that the use of
Dict{String,AbstractField}, where fields are dynamically defined during the simulation, leads to type instability problems. Problem is solved by having two kinds of fields in the element, let's call themsfieldsanddfields, where thedfieldsis the old implementation andsfieldsis the new one.