-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use $ to eagerly evaluate expressions in @~ #90
base: master
Are you sure you want to change the base?
Conversation
This test is failing: LazyArrays.jl/test/lazymultests.jl Line 165 in 7336bc5
https://travis-ci.org/JuliaArrays/LazyArrays.jl/jobs/628247559#L302 But I don't understand why changing the macro definition would change this test. Also, I can't reproduce this locally with |
Just change it to I have no idea why an unrelated change would trigger this, and only on two builds though. |
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
+ Coverage 77.41% 77.84% +0.43%
==========================================
Files 14 14
Lines 1160 1169 +9
==========================================
+ Hits 898 910 +12
+ Misses 262 259 -3
Continue to review full report at Codecov.
|
Thanks, using |
Let me know when you want this merged |
It's good to go for me. |
With this PR, you can use
@~ A .+ $Ref(x)
to eagerly evaluate the sub-expressionRef(x)
.