Skip to content

Commit

Permalink
Letting mlflow to generate the run name and saving the model type as …
Browse files Browse the repository at this point in the history
…a run tag
  • Loading branch information
pebeto committed Aug 18, 2023
1 parent 1ca9f8a commit 48b8039
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "MLJFlow"
uuid = "7b7b8358-b45c-48ea-a8ef-7ca328ad328f"
authors = ["Jose Esparza <[email protected]>"]
version = "0.0.1"
version = "0.1.0"

[deps]
MLFlowClient = "64a0f543-368b-4a9a-827a-e71edb2a0b83"
Expand Down
10 changes: 3 additions & 7 deletions src/base.jl
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
function log_evaluation(logger::MLFlowLogger, performance_evaluation)
experiment = getorcreateexperiment(logger.service, logger.experiment_name;
artifact_location=logger.artifact_location)
model_name = name(performance_evaluation.model)
run = createrun(logger.service, experiment;
run_name="$(model_name) run",
tags=[
Dict("key" => "resampling", "value" => string(performance_evaluation.resampling)),
Dict("key" => "repeats", "value" => string(performance_evaluation.repeats)),
Dict("key" => "model type", "value" => name(performance_evaluation.model)),
]
)

Expand All @@ -23,15 +22,12 @@ function save(logger::MLFlowLogger, mach::Machine)
seekstart(io)

model = mach.model
model_name = name(model)

experiment = getorcreateexperiment(logger.service, logger.experiment_name,
artifact_location=logger.artifact_location)
run = createrun(logger.service, experiment;
run_name="$(model_name) run")
run = createrun(logger.service, experiment)

logmodelparams(logger.service, run, model)
fname = "$(model_name).jls"
logartifact(logger.service, run, fname, io)
logartifact(logger.service, run, "machine.jls", io)
updaterun(logger.service, run, "FINISHED")
end

0 comments on commit 48b8039

Please sign in to comment.