Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize noise models #16

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Generalize noise models #16

merged 3 commits into from
Nov 17, 2021

Conversation

michaelosthege
Copy link
Member

Extracted commits from #12 that relevant for generalization over independent variable distributions.

Also closes some coverage gaps.

@michaelosthege michaelosthege added the enhancement New feature or request label Nov 16, 2021
@michaelosthege michaelosthege self-assigned this Nov 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021 •
edited
Loading

Codecov Report

Merging #16 (cf05dd9) into master (168b5cf) will increase coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   93.68%   93.83%   +0.15%     
==========================================
  Files           5        5              
  Lines         665      665              
==========================================
+ Hits          623      624       +1     
+ Misses         42       41       -1
Impacted Files Coverage Δ
calibr8/contrib/base.py 96.11% <0.00%> (ø)
calibr8/core.py 96.05% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 168b5cf...cf05dd9. Read the comment docs.

@michaelosthege michaelosthege mentioned this pull request Nov 16, 2021
Merged
13 tasks
lhelleckes
lhelleckes requested changes Nov 17, 2021
View reviewed changes
Copy link
Member

@lhelleckes lhelleckes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need some clarification, maybe in the docstrings / ReadTheDocs as well. Not sure if the new functionality is otherwise understandable for the user.

calibr8/contrib/noise.py Show resolved Hide resolved
calibr8/tests.py Outdated Show resolved Hide resolved
calibr8/core.py Show resolved Hide resolved
calibr8/core.py Show resolved Hide resolved
calibr8/tests.py Show resolved Hide resolved
docs/source/calibr8_inheritance.md Show resolved Hide resolved
docs/source/calibr8_inheritance.md Outdated Show resolved Hide resolved
docs/source/calibr8_inheritance.md Show resolved Hide resolved
@michaelosthege michaelosthege force-pushed the generalize-noise-models branch 2 times, most recently from 08fb02e to 9db0829 Compare November 17, 2021 14:21
lhelleckes
lhelleckes approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@lhelleckes lhelleckes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for now because the remaining tests are tackled in other issues.

@michaelosthege michaelosthege merged commit 38738a5 into master Nov 17, 2021
@michaelosthege michaelosthege deleted the generalize-noise-models branch November 17, 2021 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhelleckes lhelleckes lhelleckes approved these changes

Assignees

@michaelosthege michaelosthege

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelosthege @codecov-commenter @lhelleckes