Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the loglikelihood and likelihood shape broadcasting #15

Open
michaelosthege opened this issue Nov 16, 2021 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@michaelosthege
Copy link
Member

Working on #12 I started changing the broadcasting behavior of CalibrationModel.likelihood and CalibrationModel.loglikelihood, but it's not as simple and deserves it's very own issue & PR.

What needs to be done:

  • Come up with a comprehensive list of shape_indep, shape_obs, model_ndim, scan_x combinations and precisely define the shape_expected.
  • Keep in mind that shape_indep may be higher-dimensional, for example when broadcasting with a 5-dimensional tensor..
  • Critically analyze: Do we even need scan_x if the broadcasting behavior is clearly defined?
  • Make the necessary changes to CalibrationModel.loglikelihood and CalibrationModel.likelihood
@michaelosthege michaelosthege added the enhancement New feature or request label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant