-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create and publish typescript package #62
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
test publishing to |
npm package names must be lowercase. Would |
…typescript + autoformat Graal.d.ts because i couldn't block the IDE from doing it
6383d11
to
934fe44
Compare
Updated branch @mart3323/jsmacros-types on npm |
per wagyourtail's comment in JsMacros#62, beta builds should not deploy to npm.
buildSrc/src/main/java/xyz/wagyourtail/doclet/tsdoclet/Main.java
Outdated
Show resolved
Hide resolved
docs/typescript/package.json
Outdated
@@ -0,0 +1,33 @@ | |||
{ | |||
"name": "@mart3323/jsmacros-types", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have grabbed the @jsmacros
org. want me to add you to it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to you - though keep in mind that as soon as we switch to the final package name, anything published (including from this unmerged MR) will become locked in. NPM does not allow editing/republishing to the same combination of package name and version number
source: https://docs.npmjs.com/policies/unpublish
If/When this is otherwise ready to merge, i would like to clean up the history with a quick interactive rebase first |
yeah. I think the requested changes are wrapping up, feel free to add back the beta actually... I haven't really done too much with npm, but I should've invited you to the org. |
Removed comments that merely explain the syntax (likely leftovers from an example file) I assume they were not left in intentionally because none of the other CI files have them
e4c5229
to
36aa048
Compare
Rebase complete. publish for beta reincluded Added one final extra change - I noticed a comment in the build script was outdated
so i deleted that. Since none of the other .yml files had comments like those, i figured i'd remove them from betabuild.yml as well to declutter it |
in #72, the only feature i spotted that is missing here is building a .tgz artifact. It feels unnecessary here, since but i also don't have experience with tgz files so I might just not be thinking of the right use cases |
The reason i include the package in the artifact is that i dont have to get the sha of the beta build. |
81c2e63
to
1f91242
Compare
But other than downloading the types as a .tgz and downloading the Mod at the same time, there is no other benefit |
From #todo/jsmacros/14
Changes
For the npm package
Unrelated
Note on compatibility with main-1.19
The current 1.19 branch reports errors for basic scripts such as
Chat.log("string")
not because the packaging is wrong, but because the generated .d.ts file now contains the type_javatypes.java.lang.Object
in a bunch of places.For testing i put these changes directly on the 1.7.0 release and the packages produced from that version worked fine