Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a SKIP_ORION option to the start script #5091

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thesan
Copy link
Member

@thesan thesan commented Mar 4, 2024

This is just a DX thing but I keep on adding this to the start script.

Here's why: only Atlas usues Orion, and a lot of the work on Atlas is done using a playgrounds ATM. OTOH when working on Orion directly IMO it's easier to run Orion from the local repository not from the monorepos.

@thesan thesan requested a review from mnaamani March 4, 2024 11:13
Copy link
Member

@mnaamani mnaamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, I find myself doing the same as well.
But we still need storage-squid to run ..


## Storage Squid
docker-compose -f ./docker-compose.storage-squid.yml up -d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you mean to also prevent storage-squid from starting up if SKIP_ORION == true
The storage infra needs it to function, as they do not rely on query node anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants