fix(docker-registry-ui): unable to use persistent volume from existin…

…g claim (#3) fixes #3
Joxit · Aug 31, 2022 · 3599395 · 3599395
1 parent c32eb55
commit 3599395
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/charts/docker-registry-ui/Chart.yaml b/charts/docker-registry-ui/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 name: docker-registry-ui
-version: 0.2.0
+version: 0.2.1
 appVersion: "2.2.1"
 kubeVersion: ">=1.19.0-0"
 description: The simplest and most complete UI for your private registry

diff --git a/charts/docker-registry-ui/README.md b/charts/docker-registry-ui/README.md
@@ -73,7 +73,7 @@ helm upgrade --install docker-registry-ui joxit/docker-registry-ui
 | `registry.image` | `registry:2.8.1` | The name and tag of the docker registry server image |
 | `registry.imagePullSecrets` | `-` | Override default image pull secrets |
 | `registry.imagePullPolicy` | `-` | Override default pull policy |
-| `dataVolume.emptyDir` | `{}` | Configuration for the data directory |
+| `registry.dataVolume` | `null` | Configuration for the data directory. When null it will create an emptyDir. |
 | `registry.resources` | `{}` | The resource settings for registry server pod. |
 | `registry.nodeSelector` | `{}` | Optional YAML string to specify a nodeSelector config. |
 | `registry.tolerations` | `[]` | Optional YAML string to specify tolerations. |

diff --git a/charts/docker-registry-ui/templates/registry-deployment.yaml b/charts/docker-registry-ui/templates/registry-deployment.yaml
@@ -47,7 +47,11 @@ spec:
             {{- toYaml .Values.registry.resources | nindent 12 }}
       volumes:
         - name: data
-          {{- toYaml .Values.registry.dataVolume | nindent 10 }}
+          {{- if .Values.registry.dataVolume }}
+            {{- toYaml .Values.registry.dataVolume | nindent 10 }}
+          {{- else }}
+          emptyDir: {}
+          {{- end }}
       {{- with .Values.registry.nodeSelector }}
       nodeSelector:
         {{- toYaml . | nindent 8 | trim }}

diff --git a/charts/docker-registry-ui/values.yaml b/charts/docker-registry-ui/values.yaml
@@ -85,9 +85,8 @@ registry:
   imagePullSecrets: "-"
   # Override default pull policy
   imagePullPolicy: "-"
-  # Configuration for the data directory
-  dataVolume:
-    emptyDir: {}
+  # Configuration for the data directory.  When null it will create an emptyDir.
+  dataVolume: null
   # The resource settings for registry server pod.
   resources: {}
   # Optional YAML string to specify a nodeSelector config.