Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover Sherpa analysis status when fitting PCA backgrounds #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ruizca
Copy link
Contributor

@ruizca ruizca commented Mar 17, 2022

This pull request address issue #34

@JohannesBuchner
Copy link
Owner

This looks good. Nice and clean code.

Did you test it?

I have to set up Github actions first, so that this can be tested (since the last BXA release, travis-CI removed their permanently-free open source tier).

But I wonder if the alternative approach you suggested, may not be better, because it requires less code to maintain. By that I mean documenting the behaviour so that users are aware. That would be editing this document: doc/pca-background-models.rst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants