clean: modularize TCP connection handling #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbruens
approved these changes
Mar 15, 2024
Would we want to create an interface where new proxy protocols would implement |
|
Yes, we probably want to define some interface, but it still needs some cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clearly separates authentication, proxy request extraction and proxy handling. This is a move towards supporting multiple protocols.
New transports can be implemented to replace the
authenticatecall.New proxy protocols can be implemented to replace the
getProxyRequestcall. We can even support multiple protocols by sniffing the connection requests.The
proxyConnectioncall shouldn't change with different protocols.