Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use Unpack in findEntry #149

Merged
merged 1 commit into from
Apr 28, 2023
Merged

refactor: use Unpack in findEntry #149

merged 1 commit into from
Apr 28, 2023

Conversation

fortuna
Copy link

@fortuna fortuna commented Apr 25, 2023

No description provided.

@fortuna fortuna mentioned this pull request Apr 25, 2023
Merged
@fortuna fortuna marked this pull request as ready for review April 27, 2023 15:20
@fortuna fortuna requested a review from a team as a code owner April 27, 2023 15:20
@fortuna fortuna requested review from jyyi1 and removed request for a team April 27, 2023 15:20
jyyi1
jyyi1 approved these changes Apr 27, 2023
View reviewed changes
Copy link

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please merge the other PR before merging this one.

@fortuna fortuna changed the title Use Unpack in findEntry refactor: use Unpack in findEntry Apr 28, 2023
@fortuna fortuna merged commit 7798d19 into master Apr 28, 2023
@fortuna fortuna deleted the fortuna-unpack branch April 28, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyyi1 jyyi1 jyyi1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fortuna @jyyi1