Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: support build for multi-arch builds #598

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

oreoluwa
Copy link
Contributor

@oreoluwa oreoluwa commented Mar 3, 2020

@JonathanDCohen closing #496 in favor of this.
With seihon we can easily publish the image for multiple platforms and architectures using the docker manifest feature, while providing a build template. the image that is ultimately deployed would be runnable on any of the supported platforms. By default seihon builds for arm.v6, arm.v7, arm.v8, amd64, 386 however our base image node:8.15.0-alpine doesn't have the arm.v7 manifest included, but the v7 architecture can run v6 build.
Please let me know your thoughts on this.

Jonathan Cohen and others added 6 commits February 11, 2020 16:31
…-Code#574)

* Correctly internationalize new UI access key placeholder name

* Add back the keyID for non-English languages

This simply replicates the existing messages so we can release the Data
Limits UI without waiting for these strings to be translated.

* Specify that keyId will be a number
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@oreoluwa
Copy link
Contributor Author

oreoluwa commented Mar 3, 2020

@googlebot I consent.

1 similar comment
@andela-oakinniranye
Copy link

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Mar 3, 2020
@JonathanDCohen
Copy link
Contributor

seihon looks really cool, but on https://docs.docker.com/engine/reference/commandline/manifest/ it warns that docker manifests are still experimental and shouldn't be used in production.

@alalamav @fortuna Maybe we could push experimental or unstable manifest lists until docker manifest stabilizes? Otherwise we could do this the hard way without docker manifest

And I guess also we should hold until we can get full arm support. I don't know what the distribution is like in the wild of the different versions of arm devices.

@lomax
Copy link

lomax commented Oct 27, 2021

And I guess also we should hold until we can get full arm support. I don't know what the distribution is like in the wild of the different versions of arm devices.

There are ARM's in the cloud. Could we get arch-tagged images while docker manifest is still experimental?

@richardzone
Copy link

Any update on this?

@oreoluwa oreoluwa requested a review from a team as a code owner August 2, 2022 21:24
@oreoluwa oreoluwa requested a review from a team as a code owner January 19, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants