Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated steps to set firewall rules for AWS and attached 3 more 'X' to 'outline_logXXX' #1386

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updated steps to set firewall rules for AWS and attached 3 more 'X' to 'outline_logXXX' #1386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acd82c7
Updated steps to set up firewall rules for AWS in 'en.json'
QingXXiong Aug 10, 2023
04855fe
Fix the version value in package-lock.json
QingXXiong Aug 11, 2023
852b9b7
Update package-lock.json
QingXXiong Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/server_manager/install_scripts/install_server.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ readonly SENTRY_LOG_FILE=${SENTRY_LOG_FILE:-}
# - STDERR is only used in the event of a fatal error
# - Detailed logs are recorded to this FULL_LOG, which is preserved if an error occurred.
# - The most recent error is stored in LAST_ERROR, which is never preserved.
FULL_LOG="$(mktemp -t outline_logXXX)"
LAST_ERROR="$(mktemp -t outline_last_errorXXX)"
FULL_LOG="$(mktemp -t outline_logXXXXXX)"
LAST_ERROR="$(mktemp -t outline_last_errorXXXXXX)"
readonly FULL_LOG LAST_ERROR

function log_command() {
Expand Down
6 changes: 3 additions & 3 deletions src/server_manager/messages/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
"aws-lightsail-firewall-0": "Navigate to the {openLink}Amazon Lightsail{closeLink} instances screen.",
"aws-lightsail-firewall-1": "Click the instance on which you want to host Outline.",
"aws-lightsail-firewall-2": "Navigate to the 'Networking' tab.",
"aws-lightsail-firewall-3": "In the 'Firewall' section, click 'Add another'.",
"aws-lightsail-firewall-4": "Set 'Application' value to 'All TCP+UDP'.",
"aws-lightsail-firewall-5": "Click 'Save'.",
"aws-lightsail-firewall-3": "Scroll down to 'IPv6 firewall', then click 'Add rule'.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about IPv4?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS'll auto-create the same rules for IPv4 by default.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other ways also exist for setting up the rule, but I believe these steps are quick and easy.

"aws-lightsail-firewall-4": "Select 'All protocols' for 'Application'.",
"aws-lightsail-firewall-5": "Click 'Create' on the right to save your rule.",
"cancel": "Cancel",
"geo-amsterdam": "Amsterdam",
"geo-bangalore": "Bangalore",
Expand Down