Allow to run Outline on a server with another Watchtower #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekSi
force-pushed
the
watchtower-scope
branch
from
57130f7
to
b0e7303
Compare
fortuna
reviewed
Dec 21, 2022
| @@ -304,6 +304,7 @@ function start_shadowbox() { | |||
| local -ar docker_shadowbox_flags=( | |||
| --name "${CONTAINER_NAME}" --restart always --net host | |||
| --label 'com.centurylinklabs.watchtower.enable=true' | |||
| --label 'com.centurylinklabs.watchtower.scope=shadowbox' | |||
There was a problem hiding this comment.
Will this prevent watchtower itself from being updated?
There was a problem hiding this comment.
No, the label and the flag will be applied simultaneously. So old version without the label and the flag will update itself to a new version with the label and the flag.
There was a problem hiding this comment.
Changed scope name to make it a bit more explicit. PTAL
See https://containrrr.dev/watchtower/running-multiple-instances/ `com.centurylinklabs.watchtower.enable` and `--label-enable` are kept for backward compatibility. Closes Jigsaw-Code#48.
AlekSi
force-pushed
the
watchtower-scope
branch
from
b0e7303
to
7720e77
Compare
afterein
reviewed
Feb 3, 2023
| @@ -333,10 +334,12 @@ function start_watchtower() { | |||
| # testing). Otherwise refresh every hour. | |||
| local -ir WATCHTOWER_REFRESH_SECONDS="${WATCHTOWER_REFRESH_SECONDS:-3600}" | |||
| local -ar docker_watchtower_flags=(--name watchtower --restart always \ | |||
| --label 'com.centurylinklabs.watchtower.enable=true' \ | |||
There was a problem hiding this comment.
furthermore, this change now allows watchtower to update itself
right now every instance of outline-server has its watchtower image stuck on the installation version due to the presence of --label-enable
|
Ping |
|
@fortuna poke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://containrrr.dev/watchtower/running-multiple-instances/
com.centurylinklabs.watchtower.enableand--label-enableare kept for backward compatibility.Closes #48.