Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update deps #1227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: update deps #1227

wants to merge 1 commit into from
+3,564 −2,240

Conversation

fortuna
Copy link
Collaborator

@fortuna fortuna commented Nov 18, 2022 •
edited

For the record, I used npx npm-check-updates --target minor -ws --root -u, followed by npm install. Also did npm audit fix after that, but it failed.

@fortuna fortuna requested a review from a team as a code owner November 18, 2022 23:57
@fortuna fortuna requested review from daniellacosse and jyyi1 and removed request for a team November 18, 2022 23:58
@fortuna fortuna changed the title Update deps chore: update deps Nov 18, 2022
daniellacosse
daniellacosse reviewed Nov 21, 2022
View reviewed changes
Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many vulnerabilities were left? We should make sure to the same thing to the client. Also fix the failing test.

jyyi1
jyyi1 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyyi1
Copy link
Contributor

jyyi1 commented Nov 22, 2022

LGTM

But the build seems to be consistently failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellacosse daniellacosse daniellacosse left review comments

@jyyi1 jyyi1 jyyi1 approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fortuna @jyyi1 @daniellacosse