Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #2428 #2429

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Resolves #2428 #2429

wants to merge 2 commits into from

Conversation

bozoslivehere
Copy link

@bozoslivehere bozoslivehere commented Apr 14, 2024

The --sortby flag is only implemented for name. This commit adds the functionality to sort by base, baseid, id, modified, popularity, submitted, and votes - the commands said to be available in man yay:

       --sortby <votes|popularity|id|baseid|name|base|submitted|modified>
              Sort AUR results by a specific field during search.

@bozoslivehere bozoslivehere requested a review from Jguer as a code owner April 14, 2024 19:34
Copy link
Author

@bozoslivehere bozoslivehere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for workflows

@bozoslivehere
Copy link
Author

Just bumping this, it's been 2 weeks.

@Jguer
Copy link
Owner

Jguer commented May 2, 2024

Hi @bozoslivehere , thanks for submitting this PR. Have you considered what should be the default behavior if the metric is not available?

(ex: repo packages https://github.com/Jguer/yay/pull/2429/files#diff-a6b646c5a4d3d0efa99be23d2da0d3e0bf20eaa920831b4cea03500cb0c71f70R231)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants