Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #2387 #2391

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

Fixed issue #2387 #2391

wants to merge 4 commits into from

Conversation

theaino
Copy link

@theaino theaino commented Mar 9, 2024

Fixing issue #2387

When having clone.defaultRemoteName not set to origin in the global gitconfig, the installation fails.

This is fixed by setting GIT_CONFIG_NOSYSTEM=1 when running the makepkg and git commands.
The original PKGBUILD repo is also cloned with the --origin=origin flag set, just in case.

@theaino theaino requested a review from Jguer as a code owner March 9, 2024 06:45
@Jguer
Copy link
Owner

Jguer commented Mar 15, 2024

Hey @AinoSpring , I think only keeping origin=origin the best. Some users rely on the gitconfig to handle proxies,..

@theaino
Copy link
Author

theaino commented Mar 16, 2024

The problem "somehow" happened in the makepkg commands so git flags can't be used..

I just found some other git env-vars to override config keys which also fixed the problem.

@Jguer
Copy link
Owner

Jguer commented May 2, 2024

👍 ok to merge this, testing didn't show much problems. Thanks @AinoSpring

@Jguer
Copy link
Owner

Jguer commented May 13, 2024

Hey @AinoSpring , I think your rebase might have failed. Would you be available for handling it?

@theaino theaino requested a review from Jguer August 22, 2024 16:16
@Jguer
Copy link
Owner

Jguer commented Oct 1, 2024

@theaino can you git merge origin/next on this please?

@theaino
Copy link
Author

theaino commented Oct 1, 2024

@Jguer doesn't do anything.

@Jguer
Copy link
Owner

Jguer commented Oct 3, 2024

git fetch origin
git merge origin/next

this should do it

@theaino
Copy link
Author

theaino commented Oct 3, 2024

@Jguer perfect, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants