-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #2387 #2391
base: next
Are you sure you want to change the base?
Fixed issue #2387 #2391
Conversation
Hey @AinoSpring , I think only keeping origin=origin the best. Some users rely on the gitconfig to handle proxies,.. |
The problem "somehow" happened in the makepkg commands so git flags can't be used.. I just found some other git env-vars to override config keys which also fixed the problem. |
👍 ok to merge this, testing didn't show much problems. Thanks @AinoSpring |
Hey @AinoSpring , I think your rebase might have failed. Would you be available for handling it? |
Signed-off-by: Aino Spring <[email protected]>
Signed-off-by: Aino Spring <[email protected]>
@theaino can you |
@Jguer doesn't do anything. |
this should do it |
@Jguer perfect, thanks |
Fixing issue #2387
When having
clone.defaultRemoteName
not set to origin in the globalgitconfig
, the installation fails.This is fixed by setting
GIT_CONFIG_NOSYSTEM=1
when running the makepkg and git commands.The original PKGBUILD repo is also cloned with the
--origin=origin
flag set, just in case.