Fixed issue #2387 #2391
Open
Fixed issue #2387 #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @AinoSpring , I think only keeping origin=origin the best. Some users rely on the gitconfig to handle proxies,.. |
|
The problem "somehow" happened in the makepkg commands so git flags can't be used.. I just found some other git env-vars to override config keys which also fixed the problem. |
Jguer
approved these changes
May 2, 2024
|
👍 ok to merge this, testing didn't show much problems. Thanks @AinoSpring |
|
Hey @AinoSpring , I think your rebase might have failed. Would you be available for handling it? |
Signed-off-by: Aino Spring <[email protected]>
Signed-off-by: Aino Spring <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #2387
When having
clone.defaultRemoteNamenot set to origin in the globalgitconfig, the installation fails.This is fixed by setting
GIT_CONFIG_NOSYSTEM=1when running the makepkg and git commands.The original PKGBUILD repo is also cloned with the
--origin=originflag set, just in case.