Improve autoscroll by automatically search for scroll container #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the CHANGELOG more readable, as new lines aren't interpreted as line breaks, but list items are
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <[email protected]>
…yarn/elliptic-6.5.4 Bump elliptic from 6.5.3 to 6.5.4
Update CHANGELOG.md
merge in master branch
Fix bug when autoscroll does not work correctly with useWindowAsScrollContainer. document.body has no scrollTop value in several cases, but document.documentElement works fine always.
Fix bug with autoscroll
Currently the scrolling container is the container itself, however sometimes the SlickList is not scrollable, but is embedded inside a scrollable parent. This commit searches for the scrollable element instead of using the default container, so that autoscroll works when SlickList is inside a scrollable parent.
|
Can someone merge this PR? Very helpfull if its work. |
|
Yes, can someone merge this PR soon ? |
setur52
approved these changes
Feb 21, 2022
matur367
approved these changes
Feb 21, 2022
Fixes issue Jexordexan#166
Add missing "plugin" in index.d.ts
fix: Module '"vue-slicksort"' has no exported member 'DragHandle'.ts(2305)
Fix/register events as passive
|
This would be very helpful |
|
Any chance to merge it? |
|
This would be very helpful use SlickList components inside a scrollable parent . When use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for the great library :).
I really like the autoscroll feature, however it only works if the SlickList is scrollable. However in my app, I use a few SlickList components inside a scrollable parent, and autoscroll does not work, since currently the scrolling container is the container itself.
This commit simply searches for the scrollable element instead of using the default container, so that autoscroll works when SlickList is inside a scrollable parent.
Although this is for v2, I can port to v1 if you're ok with the logic :)